starknet_committer: group generic layout logic #10852
Open
+282
−265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2025
|
This change is |
This was referenced Dec 16, 2025
Merged
Contributor
Author
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
f0f8264 to
db31e03
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
7d94911 to
b539240
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
db31e03 to
3ffdee4
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
b539240 to
da8f9ad
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
2 times, most recently
from
36a3346 to
ef3849c
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
da8f9ad to
c86afc7
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
ef3849c to
dceef18
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
c86afc7 to
38b5e43
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
38b5e43 to
45d74f5
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
dceef18 to
05ffc20
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
2 times, most recently
from
00fd19a to
a883c19
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
35dc232 to
40989d9
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
40989d9 to
9abd84d
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
a883c19 to
6d0d334
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
9abd84d to
99383f0
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
2 times, most recently
from
3fea874 to
d64ac78
Compare
nimrod-starkware
approved these changes
Dec 24, 2025
Contributor
nimrod-starkware
left a comment
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
d64ac78 to
cd7deb2
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
6fc0a09 to
1ebb81b
Compare
ArielElp
force-pushed
the
ariel/clean_skeleton_tree_configs
branch
from
1ebb81b to
aeea1f9
Compare
ArielElp
force-pushed
the
ariel/group_layout_shared_code
branch
from
cd7deb2 to
6aa6101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.