Skip to content

fix: preserve project provider identity#261

Open
mariusvniekerk wants to merge 2 commits intoembed-workspace-surfacesfrom
fix-kata-55-explicit-repo-upsert
Open

fix: preserve project provider identity#261
mariusvniekerk wants to merge 2 commits intoembed-workspace-surfacesfrom
fix-kata-55-explicit-repo-upsert

Conversation

@mariusvniekerk
Copy link
Copy Markdown
Collaborator

Project registration now requires explicit provider identity when linking a platform repo, so GitLab projects cannot be silently recorded through the old GitHub-only host/owner/name compatibility path. The legacy varargs UpsertRepo API was removed and call sites now pass RepoIdentity values.

@mariusvniekerk
Copy link
Copy Markdown
Collaborator Author

mariusvniekerk commented May 7, 2026

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (59737b1)

No Medium, High, or Critical findings were reported.

All agents that provided review content found the code clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the embed-workspace-surfaces branch from 42b9230 to c1c4dd3 Compare May 7, 2026 13:15
@mariusvniekerk mariusvniekerk force-pushed the fix-kata-55-explicit-repo-upsert branch from 59737b1 to 8fac843 Compare May 7, 2026 13:15
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (8fac843)

No Medium, High, or Critical findings were reported across the reviews.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

Project registration now requires explicit provider identity when linking a platform repo, so GitLab projects cannot be silently recorded through the old GitHub-only host/owner/name compatibility path. The legacy varargs UpsertRepo API was removed and call sites now pass RepoIdentity values.
Provider-aware project registration should keep the platform name from this branch while using platform_host for the host field to match the rest of the API.
@mariusvniekerk mariusvniekerk force-pushed the fix-kata-55-explicit-repo-upsert branch from 8fac843 to fa0483b Compare May 8, 2026 21:04
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 8, 2026

roborev: Combined Review (fa0483b)

Medium issue remains: UpsertRepo now bypasses repo identity canonicalization.

Medium

  • internal/db/queries.go:523: UpsertRepo no longer canonicalizes RepoIdentity inputs before persisting them. The previous helper normalized typed identities, but the new typed method passes values directly to upsertRepoIdentity, so mixed-case platform/host/owner/name values can create duplicate or unresolvable repo rows.
    • Fix: Canonicalize inside UpsertRepo before calling upsertRepoIdentity, so all insertion paths keep the same normalization guarantees.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant