fix: preserve nested repo paths in embeds

[mariusvniekerk]

Embed detail routes now carry repo_path as an encoded query value and derive display owner/name from it. The sidebar receives the exact repoPath so GitLab group/subgroup repositories are no longer flattened.

[mariusvniekerk]

This change is part of the following stack:

• Add embed-targetable workspace surfaces and project/worktree registry #258
  • fix: preserve project provider identity #261
    • fix: route embed details with explicit provider #262
      • fix: preserve nested repo paths in embeds #263 ◀
        • refactor: isolate workspace embed shell #264

_{Change managed by git-spice.}

[roborev-ci]

roborev: Combined Review (fd72bea)

Medium concerns remain around embed detail routing compatibility and coverage.

Medium

• frontend/src/lib/stores/router.svelte.ts:226
  The embed detail parser now only accepts the new ...?repo_path= shape, so existing simple-repo embed URLs like /workspaces/embed/detail/github/pr/github.com/acme/widgets/42 no longer resolve to the detail pane and instead fall back to the workspaces page. Keep a legacy matcher for the old path form and derive repoPath as ${owner}/${name}.

• frontend/src/lib/stores/router.test.ts:212
  The routing fix only adds router unit coverage. Add an e2e test that opens an embed detail route with a nested repo_path and verifies the real app surface loads the correct repository/detail content.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (974f6f5)

Summary verdict: One medium test coverage gap remains; no high or critical findings were reported.

Medium

• frontend/tests/e2e/workspaces.spec.ts:168
  The nested repo_path case is only covered with a mocked page.route response, so it does not exercise the real HTTP API and SQLite lookup for the encoded nested owner path. A server routing, decoding, or DB lookup regression could still ship.
  Fix: Add a full-stack e2e/API test that seeds SQLite with a nested repo path, loads the embed detail route against the real server, and asserts the returned detail content.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (8e6fd1e)

Summary: One medium-risk test coverage gap remains; no security issues were found.

Medium

• frontend/tests/e2e/workspaces.spec.ts:169
  The nested repo_path regression is covered only through a mocked Playwright API response, so it does not exercise the real HTTP API and SQLite data path needed for the user-visible fix.

  Suggested fix: Add a full-stack e2e/API test that seeds a nested repo path in SQLite, hits the real server via navigation or API, and verifies the nested issue/PR detail loads correctly.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (5b2103a)

No Medium, High, or Critical issues found.

All reviewers agreed the change is clean.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (fe18f36)

No Medium, High, or Critical issues found.

All available review outputs are clean; no actionable findings to report.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (fbcf17c)

No Medium, High, or Critical issues were reported.

All review agents that provided findings found the code clean.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (6fe535f)

No Medium, High, or Critical findings were reported; the reviewed changes look clean.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (6fd2fe9)

No Medium, High, or Critical issues found.

All reviewers agreed the change is clean.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)