feat: share Forgejo and Gitea provider core

[mariusvniekerk]

Adds a shared gitea-like provider core for SDK-free normalization, pagination, read capabilities, and typed transport error mapping before SDK converters wire into it.

[mariusvniekerk]

This change is part of the following stack:

• docs: plan Forgejo provider implementation #265
  • feat: add Forgejo and Gitea SDK client skeletons #267
    • feat: share Forgejo and Gitea provider core #268 ◀
      • feat: convert Forgejo and Gitea SDK records #269
        • feat: read Forgejo and Gitea through shared provider core #270
          • feat: start Forgejo and Gitea providers at runtime #271
            • feat: recognize Forgejo and Gitea provider configuration #266
              • test: cover Forgejo and Gitea repository imports #272
                • feat: expose Forgejo and Gitea repository imports #273
                  • test: add Forgejo and Gitea container fixtures #274
                  • feat: enable proven Forgejo and Gitea mutations #275
                  • docs: document Forgejo and Gitea setup #276
                  • feat: add gitealike Actions CI parity #281

_{Change managed by git-spice.}

[roborev-ci]

roborev: Combined Review (84ab5d3)

Medium issue found: Gitea-like PR normalization currently misclassifies locked PRs as drafts.

Medium

• internal/platform/gitealike/normalize.go:65
NormalizePullRequest maps PullRequestDTO.IsLocked into platform.MergeRequest.IsDraft. Locked PRs are not drafts, so the dashboard can show locked PRs as drafts and expose draft-only actions while real drafts are not represented.
  Fix: Add or use a dedicated draft field from the transport DTO, or leave IsDraft false when draft state is unavailable; do not derive it from IsLocked.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (35d7f58)

No Medium, High, or Critical findings were reported.

All review agents found the code clean for reportable issues.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (ed1755a)

No Medium, High, or Critical issues found.

All review agents reported no actionable findings at or above Medium severity.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (c4e4cda)

High-risk test gap: locked PR state lacks end-to-end coverage across sync, SQLite persistence, and API response.

High

• internal/platform/persist.go:40
  Locked pull request state now flows through provider normalization, persistence, and the API schema, but there is no end-to-end/API + SQLite coverage proving a locked Forgejo/Gitea PR is synced, persisted, and returned as IsLocked: true without being treated as draft.

  Fix: Add a full-stack test using a real SQLite DB and HTTP API path that syncs or seeds a locked PR, then asserts IsDraft == false and IsLocked == true in the API response.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (4e8dddc)

High concern: the PR lacks full-stack coverage for the locked PR state change.

High

• Location: internal/db/queries.go:1444, tests/e2e/
• Problem: The change persists and exposes IsLocked and fixes the Forgejo/Gitea locked-vs-draft behavior, but coverage is limited to unit tests. There is no e2e/API+SQLite test proving a locked Forgejo/Gitea PR syncs through persistence and is returned as IsLocked: true without being treated as draft.
• Fix: Add an e2e test using the real HTTP API and SQLite-backed path that verifies locked pull requests are persisted, retrieved via the API, and correctly distinguished from draft pull requests.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (9bda02e)

Medium risk: one pagination denial-of-service issue found.

Medium

• internal/platform/gitealike/provider.go:284 trusts remote pagination cursors without progress or size limits.

  A malicious or compromised Forgejo/Gitea-compatible server can return a positive Page.Next that repeats the current page or cycles between pages. collectPages will keep appending results and issuing requests until the context is canceled, which can pin the sync worker and grow memory usage.

  Remediation: enforce pagination progress and bounds, such as rejecting next.Next <= page, tracking seen pages, and adding a maximum page/item cap per collection. Consider a per-request or per-sync timeout so a bad provider response cannot monopolize sync indefinitely.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (7508c2e)

Summary verdict: No Medium, High, or Critical issues found.

All review agents reported no actionable findings above the requested severity threshold.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (d48e9c1)

Summary verdict: No Medium, High, or Critical findings were reported.

All review agents found no actionable issues to include.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (7a30080)

No medium-or-higher issues found across the reviews.

All agents reported the code as clean; there are no findings to include.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (c6466bd)

Summary verdict: No Medium, High, or Critical findings were reported.

All reviewed agents found no reportable issues.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)