selectedcontent post-connection steps did not break out of the loop #11878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use this ancestor variable. (The for each loop creates its own.)
annevk
changed the title
josepharhar
reviewed
Nov 6, 2025
| @@ -59187,12 +59185,15 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s | |||
|
|
|||
| <li><p>Otherwise, set <var>selectedcontent</var>'s <span | |||
| data-x="selectedcontent-disabled">disabled</span> state to true.</p></li> | |||
Contributor
There was a problem hiding this comment.
I think we should move the below break into this "otherwise" condition. If we always break when the ancestor is a select element, then we can't detect the nested select elements case.
Contributor
There was a problem hiding this comment.
This is also what the chromium implementation does
Member
Author
There was a problem hiding this comment.
Good point, I think this is lacking test coverage.
Member
Author
There was a problem hiding this comment.
Although if we end up finding ourselves in a nested situation, why do we still run update select's selectedcontents on the innermost select?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also has an unused ancestor variable.
/form-elements.html ( diff )