Skip to content

selectedcontent post-connection steps did not break out of the loop #11878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

selectedcontent post-connection steps did not break out of the loop #11878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ebd4b4
Remove no-op step from selectedcontent post-connection steps
annevk Nov 4, 2025
81b1309
break out of the loop
annevk Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59168,8 +59168,6 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s
<ol>
<li><p>Let <var>nearestSelectAncestor</var> be null.</p></li>

<li><p>Let <var>ancestor</var> be <var>selectedcontent</var>'s <span>parent</span>.</p></li>

<li><p>Set <var>selectedcontent</var>'s <span data-x="selectedcontent-disabled">disabled</span>
state to false.</p></li>

Expand All @@ -59187,12 +59185,15 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s

<li><p>Otherwise, set <var>selectedcontent</var>'s <span
data-x="selectedcontent-disabled">disabled</span> state to true.</p></li>
Copy link
Contributor

@josepharhar josepharhar Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move the below break into this "otherwise" condition. If we always break when the ancestor is a select element, then we can't detect the nested select elements case.

Copy link
Contributor

@josepharhar josepharhar Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also what the chromium implementation does

Copy link
Member Author

@annevk annevk Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think this is lacking test coverage.

Copy link
Member Author

@annevk annevk Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although if we end up finding ourselves in a nested situation, why do we still run update select's selectedcontents on the innermost select?


<li><p><span>Break</span>.</p></li>
</ol>
</li>

<li><p>If <var>ancestor</var> is an <code>option</code> element or a
<code>selectedcontent</code> element, then set <var>selectedcontent</var>'s <span
data-x="selectedcontent-disabled">disabled</span> state to true.</p></li>
data-x="selectedcontent-disabled">disabled</span> state to true and
<span>break</span>.</p></li>
</ol>
</li>

Expand Down