feat: add sharing debug information option to main settings screen - WPB-24712#4677
feat: add sharing debug information option to main settings screen - WPB-24712#4677
Conversation
| present(deleteDatabaseConfirmationAlert, animated: true) | ||
| } | ||
|
|
||
| func mailComposeController( |
There was a problem hiding this comment.
todo: check this change
Test Results – WireUIAll 1 files 41 suites 1m 11s ⏱️ For more details on these failures, see this check. Results for commit 86bd0f7. ♻️ This comment has been updated with latest results. |
Test Results – WireFoundationAll47 tests 47 ✅ 10s ⏱️ Results for commit 86bd0f7. ♻️ This comment has been updated with latest results. |
Test Results – Wire-iOS1 881 tests 1 854 ✅ 2m 11s ⏱️ Results for commit 86bd0f7. ♻️ This comment has been updated with latest results. |
Test Results – WireLoggingAll4 tests 4 ✅ 0s ⏱️ Results for commit 86bd0f7. ♻️ This comment has been updated with latest results. |
Test Results – WireUtilities280 tests 280 ✅ 6s ⏱️ Results for commit 86bd0f7. ♻️ This comment has been updated with latest results. |
| let isOn = keyAndValue[1] == "true" | ||
| flag.enable(isOn) | ||
| } | ||
| #if DEBUG |
There was a problem hiding this comment.
set developerFlags passed from XCUITest
| private var defaultRecordMode: SnapshotTestingConfiguration.Record? { | ||
| let ci = ProcessInfo.processInfo.environment["CI"] | ||
| return (ci == nil || ci?.isEmpty == true) ? .missing : .never | ||
| if let value = ProcessInfo.processInfo.environment["SNAPSHOT_TESTING_RECORD"], |
There was a problem hiding this comment.
now, it reads the env variable from the testplan first so if you need to record snapshots you can just modify the env value to failed and not remove the file manually
netbe
changed the title
|
1 participant
Issue
This PR reworks how sharing debug information is presented to users. It's now accessible :
Default behaviour: it still shows the DeveloperTools screen. If the Developer flag is on, it shows the action sheet. Shake again to present the DeveloperTools.
On production it only shows the action sheet.
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: