-
Notifications
You must be signed in to change notification settings - Fork 36
feat: add sharing debug information option to main settings screen - WPB-24712 #4677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
7657bcc
1c64960
c92064d
173e8a5
270e6e7
8e88362
5c5dba7
26a4756
20c7847
420467e
b22319b
fb1b505
9317a7f
407f10f
682ca10
d415271
db57a35
4f0d329
8dbc068
5c0f617
fe9fcca
124b388
1a10cab
8b4eb20
bdf2163
e43b7f6
50b4043
e982621
dda7b4f
8128d32
ce87cc3
86bd0f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,14 @@ public struct UITestConfig: Codable { | |
|
|
||
| public var isBuildBlacklisted = false | ||
|
|
||
| /// When `true`, a triple-tap on the app window triggers the same action as the shake gesture. | ||
| /// On XCUITests, shake gesture is not available. | ||
| public var useTripleTapForShakeGesture = true | ||
|
|
||
| /// Developer flags to apply at launch, keyed by `DeveloperFlag.rawValue`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thought: I wonder if we should move |
||
| /// Overrides any flags already stored in `UserDefaults`. | ||
| public var developerFlags: [String: Bool] = [:] | ||
|
|
||
| // MARK: - Init | ||
|
|
||
| public init() {} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,14 @@ public struct SnapshotHelper { | |
|
|
||
| private var defaultRecordMode: SnapshotTestingConfiguration.Record? { | ||
| let ci = ProcessInfo.processInfo.environment["CI"] | ||
| return (ci == nil || ci?.isEmpty == true) ? .missing : .never | ||
| if let value = ProcessInfo.processInfo.environment["SNAPSHOT_TESTING_RECORD"], | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now, it reads the env variable from the testplan first so if you need to record snapshots you can just modify the env value to failed and not remove the file manually |
||
| let record = SnapshotTestingConfiguration.Record(rawValue: value) { | ||
| return record | ||
| } else if ci == nil || ci?.isEmpty == true { | ||
| return .missing | ||
| } else { | ||
| return .never | ||
| } | ||
|
Comment on lines
+37
to
+44
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: This looks super helpful. |
||
| } | ||
|
|
||
| public init() {} | ||
|
|
@@ -360,7 +367,7 @@ public struct SnapshotHelper { | |
| matching value: UIViewController, | ||
| size: CGSize? = nil, | ||
| named name: String? = nil, | ||
| record recording: Bool = false, | ||
| record recording: Bool? = nil, | ||
| file: StaticString = #filePath, | ||
| testName: String = #function, | ||
| safeArea: UIEdgeInsets = .zero, | ||
|
|
@@ -522,7 +529,7 @@ public struct SnapshotHelper { | |
| public func verify( | ||
| matching value: UIImage, | ||
| named name: String? = nil, | ||
| record recording: Bool = false, | ||
| record recording: Bool? = nil, | ||
| file: StaticString = #filePath, | ||
| testName: String = #function, | ||
| line: UInt = #line | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,18 +20,43 @@ | |
|
|
||
| public enum WireTextStyle: String, CaseIterable, Sendable { | ||
|
|
||
| /// Style iOS & Figma: ? | ||
| case largeTitle | ||
|
|
||
| /// Style iOS & Figma: Title 3 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: Adding comments here. I guess at some point we should rename things to match Figma design system if it is up-to-date |
||
| case h1 | ||
|
|
||
| /// Style iOS & Figma: Title 3 (bold) - Emphasized | ||
| case h2 | ||
|
|
||
| /// Style iOS & Figma: Headline | ||
| case h3 | ||
|
|
||
| /// Style iOS & Figma: Subheadline | ||
| case h4 | ||
|
|
||
| /// Style iOS & Figma: Footnote | ||
| case h5 | ||
|
|
||
| /// Style iOS & Figma: Body | ||
| case body1 | ||
|
|
||
| /// Style iOS & Figma: Body 2 (custom) | ||
| case body2 | ||
|
|
||
| /// Figma: Callout (bold) - Emphasized | ||
| case body3 | ||
|
|
||
| /// Style iOS & Figma: Caption 1 | ||
| case subline1 | ||
|
|
||
| /// Style iOS & Figma: Caption 1 (bold) - Emphasized | ||
| case subline2 | ||
|
|
||
| /// Style iOS & Figma: Button Small (custom) | ||
| case buttonSmall | ||
|
|
||
| /// Style iOS & Figma: Button Big (custom) | ||
| case buttonBig | ||
|
|
||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thought (out of scope): This test looks weird. I hope our tab bar never looks like that in reality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Have this disabled by default and only enable it in the setup of the UITests that use it.
issue(maybe): I was looking at UITestConfig yesterday and realized that we should change something... Currently if
UITestConfig.environmentreturns a default if it is not set in the environment. I think it should return nil. I think the in the current implementation any kind of debug build will have useTripleTapForShakeGesture, not just UI tests