apollo_storage: change ServerConfig default port #10856

nadin-Starkware · 2025-12-17T08:09:03Z

No description provided.

reviewable-StarkWare · 2025-12-17T08:09:11Z

This change is

github-actions · 2025-12-17T08:09:17Z

Artifacts upload workflows:

nadin-Starkware · 2025-12-17T08:09:29Z

apollo_storage: change ServerConfig default port #10856 👈 (View in Graphite)
apollo_state_sync_config: add storage_reader_server_config to the state sync config #10808 : 1 other dependent PR (#10824 )
apollo_storage: split ServerConfig socket into ip and port fields #10806 : 1 other dependent PR (#10829 )
apollo_batcher: add storage_reader_server to the batcher #10788
apollo_batcher_config: add storage_reader_server_config to the batcher config #10787
apollo_storage: add open_storage_with_metric_and_server fn #10781
apollo_storage: pass StorageReader to create_storage_reader_server #10771
apollo_storage: impl SerializeConfig for storage reader ServerConfig #10662 : 1 other dependent PR (#10663 )
apollo_class_manager_types: add ClassManagerStorageReaderServerHandler #10630
apollo_state_sync_types: add StateSyncStorageReaderServerHandler #10628
apollo_batcher_types: add BatcherStorageReaderServerHandler #10627
apollo_storage: add error handling tests for storage reader server #10613
apollo_storage: add tests for storage reader server #10612
main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

Itay-Tsabary-Starkware

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

crates/apollo_deployments/resources/app_configs/state_sync_config.json line 66 at r1 (raw file):

  "state_sync_config.storage_reader_server_config.enable": false,
  "state_sync_config.storage_reader_server_config.ip": "0.0.0.0",
  "state_sync_config.storage_reader_server_config.port": 8091

I expect to see changes in the core.yaml file as well

Code quote:

 "state_sync_config.storage_reader_server_config.port": 8091

graphite-app · 2025-12-17T09:08:57Z

Merge activity

Dec 17, 9:08 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Dec 21, 11:58 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
Dec 21, 11:58 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

nadin-Starkware

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

crates/apollo_deployments/resources/app_configs/state_sync_config.json line 66 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

I expect to see changes in the core.yaml file as well

Done.

Itay-Tsabary-Starkware

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)

deployments/sequencer2/configs/overlays/hybrid/testing/node-0/services/core.yaml line 54 at r2 (raw file):

    state_sync_config_p2p_sync_client_config_is_none: false
    state_sync_config_rpc_config_port: 8090
    state_sync_config_storage_reader_server_config_port: 8091

They can't both use the same port

Code quote:

state_sync_config_storage_reader_server_config_port: 8091

Itay-Tsabary-Starkware

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)

deployments/sequencer2/configs/overlays/hybrid/testing/node-0/services/core.yaml line 54 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

They can't both use the same port

They = the batcher and the state sync

nadin-Starkware

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

deployments/sequencer2/configs/overlays/hybrid/testing/node-0/services/core.yaml line 54 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

They = the batcher and the state sync

Even when the server is disabled?

Itay-Tsabary-Starkware

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).

deployments/sequencer2/configs/overlays/hybrid/testing/node-0/services/core.yaml line 54 at r2 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Even when the server is disabled?

Well yea that will work, but then when we end up turning them we'd get an error.

Itay-Tsabary-Starkware

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware).

deployments/sequencer2/configs/overlays/hybrid/testing/node-0/services/core.yaml line 54 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Well yea that will work, but then when we end up turning them we'd get an error.

So better to address that now, no?

nadin-Starkware

@nadin-Starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).

deployments/sequencer2/configs/overlays/hybrid/testing/node-0/services/core.yaml line 54 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

So better to address that now, no?

Done.

Itay-Tsabary-Starkware

@Itay-Tsabary-Starkware reviewed 6 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).

nadin-Starkware

@nadin-Starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).

nadin-Starkware mentioned this pull request Dec 17, 2025

apollo_state_sync_config: add storage_reader_server_config to the state sync config #10808

Merged

nadin-Starkware marked this pull request as ready for review December 17, 2025 08:09

nadin-Starkware mentioned this pull request Dec 17, 2025

apollo_state_sync: add storage_reader_server to the state sync #10824

Merged

nadin-Starkware requested a review from Itay-Tsabary-Starkware December 17, 2025 08:09

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from 6abc5b6 to 0b52fc4 Compare December 17, 2025 08:11

Itay-Tsabary-Starkware requested changes Dec 17, 2025

View reviewed changes

nadin-Starkware force-pushed the 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config branch from e0ddd78 to f8d2777 Compare December 17, 2025 08:38

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from 0b52fc4 to 1aa0740 Compare December 17, 2025 08:38

nadin-Starkware force-pushed the 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config branch from f8d2777 to f45bf5f Compare December 17, 2025 08:41

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from 1aa0740 to e180ebf Compare December 17, 2025 08:41

nadin-Starkware changed the base branch from 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config to main-v0.14.1 December 17, 2025 09:08

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from e180ebf to 19c91b2 Compare December 17, 2025 09:08

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch 2 times, most recently from f3e012a to 39f83fd Compare December 17, 2025 09:35

nadin-Starkware commented Dec 17, 2025

View reviewed changes

Itay-Tsabary-Starkware requested changes Dec 17, 2025

View reviewed changes

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from 39f83fd to c4e42b1 Compare December 17, 2025 10:20

nadin-Starkware commented Dec 17, 2025

View reviewed changes

Itay-Tsabary-Starkware requested changes Dec 21, 2025

View reviewed changes

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from c4e42b1 to b5a51af Compare December 22, 2025 10:51

nadin-Starkware commented Dec 22, 2025

View reviewed changes

Itay-Tsabary-Starkware approved these changes Dec 22, 2025

View reviewed changes

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from b5a51af to cab7ffe Compare December 23, 2025 09:59

apollo_storage: change ServerConfig default port

066588d

nadin-Starkware force-pushed the 12-17-apollo_storage_change_serverconfig_default_port branch from cab7ffe to 066588d Compare December 23, 2025 10:47

nadin-Starkware commented Dec 23, 2025

View reviewed changes

nadin-Starkware added this pull request to the merge queue Dec 23, 2025

Merged via the queue into main-v0.14.1 with commit 40e3325 Dec 23, 2025
19 checks passed

apollo_storage: change ServerConfig default port #10856

apollo_storage: change ServerConfig default port #10856

Uh oh!

Conversation

nadin-Starkware commented Dec 17, 2025

Uh oh!

reviewable-StarkWare commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nadin-Starkware commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

nadin-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

nadin-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

nadin-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

nadin-Starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 17, 2025 •

edited

Loading

nadin-Starkware commented Dec 17, 2025 •

edited

Loading

graphite-app bot commented Dec 17, 2025 •

edited

Loading