apollo_state_sync_config: add storage_reader_server_config to the state sync config #10808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
This was referenced Dec 15, 2025
Collaborator
Author
nadin-Starkware
force-pushed
the
12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config
branch
from
535bb53 to
e30b5b0
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_split_serverconfig_socket_into_ip_and_port_fields
branch
from
be03b70 to
526788e
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config
branch
2 times, most recently
from
49cd8c7 to
b18ce41
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_split_serverconfig_socket_into_ip_and_port_fields
branch
from
526788e to
04dbb1f
Compare
Itay-Tsabary-Starkware
approved these changes
Dec 16, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 3 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
Itay-Tsabary-Starkware
requested changes
Dec 16, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/apollo_deployments/resources/app_configs/state_sync_config.json line 66 at r2 (raw file):
"state_sync_config.storage_reader_server_config.enable": false, "state_sync_config.storage_reader_server_config.ip": "0.0.0.0", "state_sync_config.storage_reader_server_config.port": 8080
Probably better using a different port -- 8080 is used elsewhere
Code quote:
8080
nadin-Starkware
force-pushed
the
12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config
branch
from
b18ce41 to
d4cfea8
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_split_serverconfig_socket_into_ip_and_port_fields
branch
from
04dbb1f to
7e4de26
Compare
This was referenced Dec 16, 2025
nadin-Starkware
force-pushed
the
12-15-apollo_storage_split_serverconfig_socket_into_ip_and_port_fields
branch
from
7e4de26 to
b5e3c94
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config
branch
from
d4cfea8 to
e0ddd78
Compare
graphite-app
bot
changed the base branch from
12-15-apollo_storage_split_serverconfig_socket_into_ip_and_port_fields
to
graphite-base/10808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.