-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_state_sync: add storage_reader_server to the state sync #10824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_state_sync: add storage_reader_server to the state sync #10824
Conversation
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
b18ce41 to
d4cfea8
Compare
cc444c3 to
35edb0d
Compare
d4cfea8 to
e0ddd78
Compare
35edb0d to
74ab95c
Compare
e0ddd78 to
f8d2777
Compare
74ab95c to
7ea2084
Compare
7ea2084 to
8838617
Compare
f8d2777 to
f45bf5f
Compare
8838617 to
ac5c349
Compare
ac5c349 to
9d7be92
Compare
Merge activity
|
eb33c24 to
a0b68b8
Compare
a0b68b8 to
60fbfee
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.
crates/apollo_state_sync/src/runner/mod.rs line 120 at r2 (raw file):
&SYNC_STORAGE_OPEN_READ_TRANSACTIONS, storage_reader_server_config, )
Let's consider using the builder pattern here.
Code quote:
open_storage_with_metric_and_server(
storage_config.clone(),
&SYNC_STORAGE_OPEN_READ_TRANSACTIONS,
storage_reader_server_config,
)
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).

No description provided.