Skip to content

Conversation

@nadin-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Itay-Tsabary-Starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware force-pushed the 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config branch from b18ce41 to d4cfea8 Compare December 16, 2025 11:34
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from cc444c3 to 35edb0d Compare December 16, 2025 11:34
@nadin-Starkware nadin-Starkware force-pushed the 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config branch from d4cfea8 to e0ddd78 Compare December 16, 2025 13:16
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from 35edb0d to 74ab95c Compare December 16, 2025 13:16
@graphite-app graphite-app bot changed the base branch from 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config to graphite-base/10824 December 17, 2025 07:12
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from 74ab95c to 7ea2084 Compare December 17, 2025 08:38
@nadin-Starkware nadin-Starkware changed the base branch from graphite-base/10824 to 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config December 17, 2025 08:38
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from 7ea2084 to 8838617 Compare December 17, 2025 08:41
@nadin-Starkware nadin-Starkware force-pushed the 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config branch from f8d2777 to f45bf5f Compare December 17, 2025 08:41
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from 8838617 to ac5c349 Compare December 17, 2025 08:58
@nadin-Starkware nadin-Starkware changed the base branch from 12-15-apollo_state_sync_config_add_storage_reader_server_config_to_the_state_sync_config to main-v0.14.1 December 17, 2025 09:08
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from ac5c349 to 9d7be92 Compare December 17, 2025 09:08
@graphite-app
Copy link

graphite-app bot commented Dec 17, 2025

Merge activity

  • Dec 17, 9:08 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch 4 times, most recently from eb33c24 to a0b68b8 Compare December 17, 2025 09:58
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_state_sync_add_storage_reader_server_to_the_state_sync branch from a0b68b8 to 60fbfee Compare December 17, 2025 10:15
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.


crates/apollo_state_sync/src/runner/mod.rs line 120 at r2 (raw file):

                &SYNC_STORAGE_OPEN_READ_TRANSACTIONS,
                storage_reader_server_config,
            )

Let's consider using the builder pattern here.

Code quote:

            open_storage_with_metric_and_server(
                storage_config.clone(),
                &SYNC_STORAGE_OPEN_READ_TRANSACTIONS,
                storage_reader_server_config,
            )

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware).

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Dec 21, 2025
Merged via the queue into main-v0.14.1 with commit 00bbe40 Dec 21, 2025
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants