-
Notifications
You must be signed in to change notification settings - Fork 3k
BaseTools: Update nasm to 2.16.01 #11844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "name": "mu_nasm", | ||
| "source": "https://api.nuget.org/v3/index.json", | ||
| "version": "2.15.5", | ||
| "version": "20016.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason the versioning scheme has changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuqin12 made that change in 2023. He can comment on the details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versioning scheme was updated to include a wrapper version for the NuGet package itself, allowing multiple pushes for the same NASM version. In this approach:
- Major version of the NuGet package encodes NASM’s major and minor version. (nasm_major * 10000 + nasm_minor)
- Minor version represents the NASM revision number.
- Revision tracks the NuGet package’s own revision (number of pushes).
For example, NASM version 2.16.1 becomes 20016.1.x, where x increments with each push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kuqin12. I'll include this info as a comment in the yaml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed the updated comment.
|
Given the recent fix for nasm 3, I am just wondering what is the reasoning (or pre-existing planning?) for going incrementally and staying with 2? |
8a0f5cb to
c9c5122
Compare
This PR is immediately addressing the fix requested in #11842 The nasm dependency has sat idle for a long time and there are multiple things that can be improved. I noted some of the more pressing issues here for follow up #11852. |
c9c5122 to
db959cf
Compare
Fixes tianocore#11842 Updates the nasm ext dep to pick up the following fix: > Fix the invalid use of RELA–type relocations instead of REL–type > relocations when generating DWARF debug information for the elf32 > output format. Signed-off-by: Michael Kubacki <[email protected]>
db959cf to
f020bfc
Compare
Description
Fixes #11842
Updates the nasm ext dep to pick up the following fix:
Note: The 2.15.5 version currently used was pushed to the current NuGet feed at https://www.nuget.org/profiles/ProjectMu in February 2021. That feed has not been actively maintained since then. The nasm version is actively pushed to this feed now https://dev.azure.com/projectmu/mu/_artifacts/feed/Basetools-Binary/NuGet/mu_nasm/overview/20016.1.1.
Therefore, that is feed used to pull this update.
How This Was Tested
Integration Instructions