Skip to content

Conversation

@makubacki
Copy link
Member

@makubacki makubacki commented Dec 5, 2025

Description

Fixes #11842

Updates the nasm ext dep to pick up the following fix:

Fix the invalid use of RELA–type relocations instead of REL–type
relocations when generating DWARF debug information for the elf32
output format.


Note: The 2.15.5 version currently used was pushed to the current NuGet feed at https://www.nuget.org/profiles/ProjectMu in February 2021. That feed has not been actively maintained since then. The nasm version is actively pushed to this feed now https://dev.azure.com/projectmu/mu/_artifacts/feed/Basetools-Binary/NuGet/mu_nasm/overview/20016.1.1.

Therefore, that is feed used to pull this update.


  • Breaking change?
  • Impacts security?
  • Includes tests?

How This Was Tested

  • CI

Integration Instructions

  • No required action expected. Review the nasm release notes for more detail about the changes between nasm 2.15.5 and nasm 2.16.01.

"name": "mu_nasm",
"source": "https://api.nuget.org/v3/index.json",
"version": "2.15.5",
"version": "20016.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the versioning scheme has changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuqin12 made that change in 2023. He can comment on the details.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdkinney @makubacki

The versioning scheme was updated to include a wrapper version for the NuGet package itself, allowing multiple pushes for the same NASM version. In this approach:

  • Major version of the NuGet package encodes NASM’s major and minor version. (nasm_major * 10000 + nasm_minor)
  • Minor version represents the NASM revision number.
  • Revision tracks the NuGet package’s own revision (number of pushes).

For example, NASM version 2.16.1 becomes 20016.1.x, where x increments with each push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kuqin12. I'll include this info as a comment in the yaml file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the updated comment.

@mikebeaton
Copy link
Member

Given the recent fix for nasm 3, I am just wondering what is the reasoning (or pre-existing planning?) for going incrementally and staying with 2?

@makubacki makubacki force-pushed the update_nasm_ext_dep_2_16_1 branch from 8a0f5cb to c9c5122 Compare December 5, 2025 15:10
@makubacki
Copy link
Member Author

Given the recent fix for nasm 3, I am just wondering what is the reasoning (or pre-existing planning?) for going incrementally and staying with 2?

This PR is immediately addressing the fix requested in #11842


The nasm dependency has sat idle for a long time and there are multiple things that can be improved. I noted some of the more pressing issues here for follow up #11852.

Fixes tianocore#11842

Updates the nasm ext dep to pick up the following fix:

> Fix the invalid use of RELA–type relocations instead of REL–type
> relocations when generating DWARF debug information for the elf32
> output format.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki force-pushed the update_nasm_ext_dep_2_16_1 branch from db959cf to f020bfc Compare December 5, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Update mu_nasm nuget release to 2.16.01 to resolve IA32 CLANGDWARF link issues

4 participants