-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_central_sync: remove base layer call to latest_proved_block #10246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_central_sync: remove base layer call to latest_proved_block #10246
Conversation
1111901 to
1b76242
Compare
993bb54 to
8432ba1
Compare
1b76242 to
8538f3c
Compare
8432ba1 to
6fa6140
Compare
2364247 to
b69e917
Compare
6fa6140 to
60ab4e9
Compare
b69e917 to
aa5b861
Compare
aa5b861 to
3886489
Compare
60ab4e9 to
f6078f4
Compare
3886489 to
247f874
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @guy-starkware)
crates/apollo_central_sync/src/sources/base_layer.rs line 34 at r1 (raw file):
Error: std::error::Error + 'static + Sync + Send, BaseLayerSource: BaseLayerContract<Error = Error> + Sync + Send, > BaseLayerSourceTrait for BaseLayerSource
Is BaseLayerSourceTrait the outward facing trait or BaseLayerContract?
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ShahakShama)
crates/apollo_central_sync/src/sources/base_layer.rs line 34 at r1 (raw file):
Previously, ShahakShama wrote…
Is BaseLayerSourceTrait the outward facing trait or BaseLayerContract?
BaseLayerContract is the thing we use in the gas price and event scrapers. This BaseLayerSourceTrait is used in the central sync crate only (IIUC it is a wrapper around the BaseLayerContract).
247f874 to
c37c0d5
Compare
f6078f4 to
2d1427f
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
c37c0d5 to
a388093
Compare

No description provided.