Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guy-starkware commented Nov 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware marked this pull request as ready for review November 18, 2025 14:53
@guy-starkware guy-starkware changed the base branch from guyn/baselayer/test_for_missing_contract to graphite-base/10246 November 18, 2025 15:28
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch from 1111901 to 1b76242 Compare November 18, 2025 15:30
@guy-starkware guy-starkware changed the base branch from graphite-base/10246 to guyn/baselayer/test_for_missing_contract November 18, 2025 15:30
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch from 1b76242 to 8538f3c Compare November 18, 2025 19:42
@guy-starkware guy-starkware force-pushed the guyn/baselayer/test_for_missing_contract branch from 8432ba1 to 6fa6140 Compare November 18, 2025 19:42
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch 2 times, most recently from 2364247 to b69e917 Compare November 19, 2025 17:45
@guy-starkware guy-starkware force-pushed the guyn/baselayer/test_for_missing_contract branch from 6fa6140 to 60ab4e9 Compare November 20, 2025 05:39
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch from b69e917 to aa5b861 Compare November 20, 2025 05:39
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch from aa5b861 to 3886489 Compare November 20, 2025 08:03
@guy-starkware guy-starkware force-pushed the guyn/baselayer/test_for_missing_contract branch from 60ab4e9 to f6078f4 Compare November 20, 2025 13:09
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch from 3886489 to 247f874 Compare November 20, 2025 13:09
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @guy-starkware)


crates/apollo_central_sync/src/sources/base_layer.rs line 34 at r1 (raw file):

    Error: std::error::Error + 'static + Sync + Send,
    BaseLayerSource: BaseLayerContract<Error = Error> + Sync + Send,
> BaseLayerSourceTrait for BaseLayerSource

Is BaseLayerSourceTrait the outward facing trait or BaseLayerContract?

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ShahakShama)


crates/apollo_central_sync/src/sources/base_layer.rs line 34 at r1 (raw file):

Previously, ShahakShama wrote…

Is BaseLayerSourceTrait the outward facing trait or BaseLayerContract?

BaseLayerContract is the thing we use in the gas price and event scrapers. This BaseLayerSourceTrait is used in the central sync crate only (IIUC it is a wrapper around the BaseLayerContract).

@guy-starkware guy-starkware changed the base branch from guyn/baselayer/test_for_missing_contract to graphite-base/10246 November 23, 2025 09:11
@guy-starkware guy-starkware force-pushed the guyn/baselayer/remove_latest_proved_block branch from 247f874 to c37c0d5 Compare November 23, 2025 09:12
@guy-starkware guy-starkware changed the base branch from graphite-base/10246 to main-v0.14.1 November 23, 2025 09:12
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants