apollo_l1_provider: remove finality_too_high helper function, add MissingBlock error

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• papyrus_base_layer: delete l1_endpoint_monitor crate #10736
• papyrus_base_layer: delete monitored base layer #10731
• apollo_l1_provider: re-write FinalityTooHigh error as LatestBlockNumberTooLow #10729
• apollo_l1_provider: use cyclic base layer wrapper instead of monitored base layer #10703
• apollo_l1_provider: make sure wrong event types do not get scraped #10700
• papyrus_base_layer: gate integration tests #10671
• apollo_l1_provider: add test for each type of L1 event we filter on #10595
• papyrus_base_layer: test util for creating an ethereum base layer using a mock provider #10588
• papyrus_base_layer: extract check and cycle URLs into a helper function with logging #10618
• papyrus_base_layer: add CyclicBaseLayerWrapper #10412
• papyrus_base_layer: make BaseLayer trait functions mutable #10404
• papyrus_base_layer: add the option to cycle the URL directly into the base layer #10357
• papyrus_base_layer: add ordered list of provider URLs to the config #10354
• apollo_l1_provider: remove finality_too_high helper function, add MissingBlock error #10348 👈 (View in Graphite)
• apollo_l1_gas_price: add test for low latest L1 block number #10346
• apollo_l1_provider: add test for low latest L1 block number #10345
• apollo_l1_provider: replace mutex with atomic u64 in a scraper test #10344
• papyrus_base_layer: remove finality from base layer #10303
• papyrus_base_layer: remove latest_l1_block from base layer #10300
• apollo_central_sync: remove base layer call to latest_proved_block #10246
• papyrus_base_layer: add test for a base layer without a starknet contract #10242
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

@ShahakShama reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware)

---

crates/apollo_l1_provider/src/l1_scraper.rs line 261 at r1 (raw file):

            .map_err(L1ScraperError::BaseLayerError)?;

        let latest_l1_block = latest_l1_block

Chain these:
let latest_l1_block = self
.base_layer
.l1_block_at(latest_l1_block_number)
.await
.map_err(L1ScraperError::BaseLayerError)?
.ok_or(L1ScraperError::MissingBlock { block_number: latest_l1_block_number })?;

---

crates/apollo_l1_provider/src/l1_scraper.rs line 433 at r1 (raw file):

    FinalityTooHigh { finality: u64, latest_l1_block_no_finality: L1BlockNumber },
    #[error("Block number {block_number} not found")]
    MissingBlock { block_number: L1BlockNumber },

This error isn't very informative. The fact that we asked for this block is an internal logic of the scraper. Maybe MissingBlockReturnedFromLatestBlockNumber? BaseLayerInconsistency?

[guy-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama)

---

crates/apollo_l1_provider/src/l1_scraper.rs line 261 at r1 (raw file):

Previously, ShahakShama wrote…

Chain these:
let latest_l1_block = self
.base_layer
.l1_block_at(latest_l1_block_number)
.await
.map_err(L1ScraperError::BaseLayerError)?
.ok_or(L1ScraperError::MissingBlock { block_number: latest_l1_block_number })?;

Done.

---

crates/apollo_l1_provider/src/l1_scraper.rs line 433 at r1 (raw file):

Previously, ShahakShama wrote…

This error isn't very informative. The fact that we asked for this block is an internal logic of the scraper. Maybe MissingBlockReturnedFromLatestBlockNumber? BaseLayerInconsistency?

LatestL1BlockNumberNoBlockFound

[ShahakShama]

@ShahakShama reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-07T14:54:31Z

[guy-starkware]

@guy-starkware reviewed 1 of 1 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[guy-starkware]

@guy-starkware reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)