-
Notifications
You must be signed in to change notification settings - Fork 65
papyrus_base_layer: add ordered list of provider URLs to the config #10354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
papyrus_base_layer: add ordered list of provider URLs to the config #10354
Conversation
714124d to
5269bc9
Compare
5269bc9 to
91246e7
Compare
2679f3f to
245a3cc
Compare
8258346 to
0f1ffb3
Compare
245a3cc to
bbf0ccb
Compare
0f1ffb3 to
751196f
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/papyrus_node/src/run.rs line 1 at r1 (raw file):
#[cfg(test)]
I think this is a rebase error. Check if this file is deleted in main-v0.14.1
bbf0ccb to
530dd2e
Compare
751196f to
ae5542a
Compare
ae5542a to
056f7d2
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 19 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)
crates/papyrus_node/src/run.rs line 1 at r1 (raw file):
Previously, ShahakShama wrote…
I think this is a rebase error. Check if this file is deleted in main-v0.14.1
Yes, this was removed. I am deleting it here, too.
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 7 of 7 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
530dd2e to
12063fb
Compare
056f7d2 to
df348e7
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 2 of 7 files at r2, 1 of 18 files at r3, 17 of 17 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
df348e7 to
664c37c
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
664c37c to
02e506f
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

No description provided.