Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guy-starkware commented Nov 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from 714124d to 5269bc9 Compare November 23, 2025 15:14
@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from 5269bc9 to 91246e7 Compare November 24, 2025 09:03
@guy-starkware guy-starkware force-pushed the guyn/l1provider/remove_error_handling_func branch from 2679f3f to 245a3cc Compare November 24, 2025 09:03
@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch 2 times, most recently from 8258346 to 0f1ffb3 Compare November 25, 2025 11:15
@guy-starkware guy-starkware force-pushed the guyn/l1provider/remove_error_handling_func branch from 245a3cc to bbf0ccb Compare December 2, 2025 11:06
@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from 0f1ffb3 to 751196f Compare December 2, 2025 11:06
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)


crates/papyrus_node/src/run.rs line 1 at r1 (raw file):

#[cfg(test)]

I think this is a rebase error. Check if this file is deleted in main-v0.14.1

@guy-starkware guy-starkware changed the base branch from guyn/l1provider/remove_error_handling_func to graphite-base/10354 December 4, 2025 13:52
@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from 751196f to ae5542a Compare December 4, 2025 13:55
@guy-starkware guy-starkware changed the base branch from graphite-base/10354 to guyn/l1provider/remove_error_handling_func December 4, 2025 13:55
@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from ae5542a to 056f7d2 Compare December 4, 2025 14:00
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 12 of 19 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)


crates/papyrus_node/src/run.rs line 1 at r1 (raw file):

Previously, ShahakShama wrote…

I think this is a rebase error. Check if this file is deleted in main-v0.14.1

Yes, this was removed. I am deleting it here, too.

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/l1provider/remove_error_handling_func branch from 530dd2e to 12063fb Compare December 7, 2025 15:15
@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from 056f7d2 to df348e7 Compare December 7, 2025 15:15
@guy-starkware guy-starkware changed the base branch from guyn/l1provider/remove_error_handling_func to main-v0.14.1 December 7, 2025 16:01
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 2 of 7 files at r2, 1 of 18 files at r3, 17 of 17 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/baselayer/config_with_url_list branch from 664c37c to 02e506f Compare December 9, 2025 08:48
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants