apollo_l1_gas_price: add test for low latest L1 block number #10346
Conversation
|
This change is |
guy-starkware
force-pushed
the
guyn/l1gas/add_test_for_low_number
branch
from
5f5d4dd to
77f1085
Compare
guy-starkware
force-pushed
the
guyn/baselayer/tests_for_bad_block_numbers
branch
from
976c083 to
7b71af3
Compare
guy-starkware
force-pushed
the
guyn/baselayer/tests_for_bad_block_numbers
branch
from
7b71af3 to
e3bf1a2
Compare
guy-starkware
force-pushed
the
guyn/l1gas/add_test_for_low_number
branch
from
77f1085 to
159b40f
Compare
guy-starkware
force-pushed
the
guyn/baselayer/tests_for_bad_block_numbers
branch
from
e3bf1a2 to
3593658
Compare
guy-starkware
force-pushed
the
guyn/l1gas/add_test_for_low_number
branch
from
159b40f to
2462126
Compare
guy-starkware
force-pushed
the
guyn/baselayer/tests_for_bad_block_numbers
branch
from
3593658 to
f408e04
Compare
guy-starkware
force-pushed
the
guyn/l1gas/add_test_for_low_number
branch
from
2462126 to
772a4b0
Compare
guy-starkware
force-pushed
the
guyn/baselayer/tests_for_bad_block_numbers
branch
from
f408e04 to
7c809c5
Compare
guy-starkware
force-pushed
the
guyn/l1gas/add_test_for_low_number
branch
from
772a4b0 to
960a899
Compare
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @guy-starkware)
a discussion (no related file):
Same comments as previous PR
a discussion (no related file):
I think we should extract this logic to a common place
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @guy-starkware)
a discussion (no related file):
Previously, ShahakShama wrote…
I think we should extract this logic to a common place
Something like finality wrapper on the base layer
guy-starkware
changed the base branch from
guyn/baselayer/tests_for_bad_block_numbers
to
graphite-base/10346
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)
a discussion (no related file):
Previously, ShahakShama wrote…
Something like finality wrapper on the base layer
Are you sure you want to add a whole other wrapper on top of the base layer (to which we are already adding a wrapper) just to encapsulate a checked_sub and an error variant?
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)
a discussion (no related file):
Previously, ShahakShama wrote…
Same comments as previous PR
Done.
guy-starkware
force-pushed
the
guyn/l1gas/add_test_for_low_number
branch
from
960a899 to
1990af4
Compare
guy-starkware
force-pushed
the
graphite-base/10346
branch
from
7c809c5 to
92e1316
Compare
guy-starkware
changed the base branch from
graphite-base/10346
to
guyn/baselayer/tests_for_bad_block_numbers
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
guy-starkware
changed the base branch from
guyn/baselayer/tests_for_bad_block_numbers
to
main-v0.14.1
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 of 3 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
No description provided.