Skip to content

starknet_transaction_prover: disable tests blocking block hash change at the request of Avi Cohen#13934

Closed
sirandreww-starkware wants to merge 1 commit into04-30-apollo_storage_add_fee_proposal_fri_migrator_and_bump_blocks_version_to_6.1from
04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen
Closed

starknet_transaction_prover: disable tests blocking block hash change at the request of Avi Cohen#13934
sirandreww-starkware wants to merge 1 commit into04-30-apollo_storage_add_fee_proposal_fri_migrator_and_bump_blocks_version_to_6.1from
04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 30, 2026

@sirandreww-starkware sirandreww-starkware self-assigned this Apr 30, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review April 30, 2026 11:46
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 30, 2026

PR Summary

Low Risk
Only affects test compilation/execution by disabling two integration tests; no production logic changes.

Overview
Disables the Sepolia VirtualSnosProver end-to-end integration tests for balanceOf and STRK transfer by gating them behind #[cfg(any())] and adding a TODO to re-enable later, effectively removing them from the test suite even when running --ignored.

Reviewed by Cursor Bugbot for commit 682867f. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents to graphite-base/13934 April 30, 2026 12:16
@sirandreww-starkware sirandreww-starkware force-pushed the 04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen branch from add4493 to c4675e0 Compare April 30, 2026 12:25
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13934 to 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents April 30, 2026 12:25
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents to graphite-base/13934 April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen branch from c4675e0 to 682867f Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13934 to 04-30-apollo_storage_add_fee_proposal_fri_migrator_and_bump_blocks_version_to_6.1 April 30, 2026 13:50
@sirandreww-starkware
Copy link
Copy Markdown
Contributor Author

No longer needed: the F2F decision is that fee_proposal will not be an input to the block hash, so the prover tests don't need to be disabled.

@github-actions github-actions Bot locked and limited conversation to collaborators May 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants