Skip to content

apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal#13818

Open
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculationfrom
04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal
Open

apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal#13818
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculationfrom
04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposals_sliding_window to graphite-base/13818 April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from e61ede6 to fec5e8d Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13818 to 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 8ccdfc9 to fe3bed1 Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 5adf1d4 to 0b7d846 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from b70aa35 to 4373775 Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch 3 times, most recently from d86d400 to f48b9c1 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 35a0ba2 to 90dacc3 Compare May 1, 2026 17:05
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from f48b9c1 to 78fa661 Compare May 1, 2026 17:05
Comment thread crates/apollo_consensus_orchestrator/src/build_proposal.rs
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 78fa661 to 9237ae1 Compare May 3, 2026 07:01
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 90dacc3 to 73eec6b Compare May 3, 2026 07:01
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 9237ae1 to c8bca61 Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 73eec6b to 9608292 Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from c8bca61 to 5492f1a Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 9608292 to 8e3056f Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 5492f1a to 99f41f5 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 8e3056f to 4bd5b4d Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 99f41f5 to a2dc0e3 Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 4bd5b4d to 972c17d Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from a2dc0e3 to 592c2d8 Compare May 4, 2026 11:14
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_fee_actual_floor_to_eip-1559_gas_price_calculation branch from 972c17d to 146f67d Compare May 4, 2026 11:14
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_consensus_orchestrator/src/snip35/mod.rs line 34 at r2 (raw file):

/// Target USD cost per L2 gas unit in atto-USD ($3e-9 = 3_000_000_000 atto-USD).
pub(crate) const TARGET_ATTO_USD_PER_L2_GAS: u128 = 3_000_000_000;

add a TODO to make this a dynamic config

Code quote:

TARGET_ATTO_USD_PER_L2_GAS

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 592c2d8 to 3605b81 Compare May 4, 2026 13:20
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3605b81. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants