apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal#13818
Conversation
This was referenced Apr 19, 2026
Closed
Closed
Contributor
Author
This was referenced Apr 19, 2026
e61ede6 to
fec5e8d
Compare
69fb04b to
8ccdfc9
Compare
This was referenced Apr 19, 2026
8ccdfc9 to
fe3bed1
Compare
5adf1d4 to
0b7d846
Compare
b70aa35 to
4373775
Compare
d86d400 to
f48b9c1
Compare
35a0ba2 to
90dacc3
Compare
f48b9c1 to
78fa661
Compare
78fa661 to
9237ae1
Compare
90dacc3 to
73eec6b
Compare
9237ae1 to
c8bca61
Compare
73eec6b to
9608292
Compare
c8bca61 to
5492f1a
Compare
9608292 to
8e3056f
Compare
5492f1a to
99f41f5
Compare
8e3056f to
4bd5b4d
Compare
99f41f5 to
a2dc0e3
Compare
4bd5b4d to
972c17d
Compare
a2dc0e3 to
592c2d8
Compare
972c17d to
146f67d
Compare
Contributor
Author
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on ShahakShama).
crates/apollo_consensus_orchestrator/src/snip35/mod.rs line 34 at r2 (raw file):
/// Target USD cost per L2 gas unit in atto-USD ($3e-9 = 3_000_000_000 atto-USD). pub(crate) const TARGET_ATTO_USD_PER_L2_GAS: u128 = 3_000_000_000;
add a TODO to make this a dynamic config
Code quote:
TARGET_ATTO_USD_PER_L2_GAS592c2d8 to
3605b81
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3605b81. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.