Skip to content

apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820

Open
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validationfrom
04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager
Open

apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validationfrom
04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Apr 19, 2026
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 6bd60bb to 8020f60 Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from cfa6f7a to 10c280c Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 8020f60 to c410076 Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 10c280c to 209889b Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from c693f3d to 7280b48 Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from ab23186 to 41b964d Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 7280b48 to 641991e Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 41b964d to 5896df2 Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 641991e to f802115 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch 2 times, most recently from ef7e93b to a965ac1 Compare May 1, 2026 17:05
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from f802115 to 74f5e86 Compare May 1, 2026 17:05
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation to graphite-base/13820 May 3, 2026 07:01
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 74f5e86 to 02d9331 Compare May 3, 2026 07:17
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13820 to 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation May 3, 2026 07:17
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 9fb345e to dcf0feb Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 02d9331 to aee5c5f Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from aee5c5f to 7d97bbf Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from dcf0feb to 4ddb820 Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 7d97bbf to b401ce7 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 4ddb820 to 436ef14 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from b401ce7 to f60926c Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch 2 times, most recently from b4e3014 to 683d6d0 Compare May 4, 2026 11:14
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fbcc234. Configure here.

// (safe but static).
strk_to_usd_oracle: Some(Arc::new(ExchangeRateOracleClient::new(
apollo_l1_gas_price_config::config::ExchangeRateOracleConfig::default(),
))),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STRK/USD oracle pollutes shared ETH/STRK global metrics

Medium Severity

The new STRK/USD oracle reuses ExchangeRateOracleClient, which internally registers and updates hardcoded global metrics named ETH_TO_STRK_* (error count, success count, rate gauge, last success timestamp). In the same node process, L1GasPriceProvider::new_with_oracle() also creates an ExchangeRateOracleClient for the actual ETH/STRK oracle. Both instances write to the same global counters and gauges, corrupting observability: error counts are inflated now (placeholder URL always fails), and once a real STRK/USD URL is configured, the eth_to_strk_rate gauge will be overwritten with STRK/USD values.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit fbcc234. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants