apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820
Conversation
6bd60bb to
8020f60
Compare
cfa6f7a to
10c280c
Compare
8020f60 to
c410076
Compare
10c280c to
209889b
Compare
c693f3d to
7280b48
Compare
ab23186 to
41b964d
Compare
7280b48 to
641991e
Compare
41b964d to
5896df2
Compare
641991e to
f802115
Compare
ef7e93b to
a965ac1
Compare
f802115 to
74f5e86
Compare
a965ac1 to
9fb345e
Compare
74f5e86 to
02d9331
Compare
9fb345e to
dcf0feb
Compare
02d9331 to
aee5c5f
Compare
aee5c5f to
7d97bbf
Compare
dcf0feb to
4ddb820
Compare
7d97bbf to
b401ce7
Compare
4ddb820 to
436ef14
Compare
b401ce7 to
f60926c
Compare
b4e3014 to
683d6d0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fbcc234. Configure here.
| // (safe but static). | ||
| strk_to_usd_oracle: Some(Arc::new(ExchangeRateOracleClient::new( | ||
| apollo_l1_gas_price_config::config::ExchangeRateOracleConfig::default(), | ||
| ))), |
There was a problem hiding this comment.
STRK/USD oracle pollutes shared ETH/STRK global metrics
Medium Severity
The new STRK/USD oracle reuses ExchangeRateOracleClient, which internally registers and updates hardcoded global metrics named ETH_TO_STRK_* (error count, success count, rate gauge, last success timestamp). In the same node process, L1GasPriceProvider::new_with_oracle() also creates an ExchangeRateOracleClient for the actual ETH/STRK oracle. Both instances write to the same global counters and gauges, corrupting observability: error counts are inflated now (placeholder URL always fails), and once a real STRK/USD URL is configured, the eth_to_strk_rate gauge will be overwritten with STRK/USD values.
Reviewed by Cursor Bugbot for commit fbcc234. Configure here.



No description provided.