starknet_api: include fee_proposal_fri in proposal commitment hash#13814
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This change is |
sirandreww-starkware
changed the base branch from
04-19-apollo_storage_add_fee_proposal_to_storageblockheader
to
graphite-base/13814
sirandreww-starkware
force-pushed
the
graphite-base/13814
branch
from
839f28c to
f202779
Compare
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
6902537 to
6068d78
Compare
sirandreww-starkware
changed the base branch from
graphite-base/13814
to
04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
6068d78 to
b586ed3
Compare
sirandreww-starkware
force-pushed
the
graphite-base/13814
branch
from
8768c1c to
add4493
Compare
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
9d1ce55 to
4d045e8
Compare
sirandreww-starkware
changed the base branch from
graphite-base/13814
to
04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4d045e8. Configure here.
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
4d045e8 to
af6bb96
Compare
sirandreww-starkware
force-pushed
the
04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen
branch
2 times, most recently
from
c4675e0 to
682867f
Compare
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
af6bb96 to
1ac2d94
Compare
sirandreww-starkware
changed the base branch from
04-30-starknet_transaction_prover_disable_tests_blocking_block_hash_change_at_the_request_of_avi_cohen
to
graphite-base/13814
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
1ac2d94 to
932f11c
Compare
sirandreww-starkware
force-pushed
the
graphite-base/13814
branch
from
682867f to
d961488
Compare
sirandreww-starkware
changed the base branch from
graphite-base/13814
to
04-30-apollo_storage_add_fee_proposal_fri_migrator_and_bump_blocks_version_to_6.1
sirandreww-starkware
changed the title
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
2 times, most recently
from
59d2ec9 to
c649130
Compare
sirandreww-starkware
force-pushed
the
04-30-apollo_storage_add_fee_proposal_fri_migrator_and_bump_blocks_version_to_6.1
branch
from
d961488 to
8eedc13
Compare
sirandreww-starkware
force-pushed
the
04-30-apollo_storage_add_fee_proposal_fri_migrator_and_bump_blocks_version_to_6.1
branch
from
8eedc13 to
a5d10f1
Compare
sirandreww-starkware
force-pushed
the
04-19-starknet_api_add_fee_proposal_to_block_hash_calculator
branch
from
c649130 to
4eeb26d
Compare
sirandreww-starkware
left a comment
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Re: crates/starknet_api/src/block_hash/block_hash_calculator.rs line 291 (chain_if_fn for SNIP-35 fee_proposal in block hash):
Obsolete after F2F decision — fee_proposal_fri is no longer an input to the block hash. It now feeds only the proposal commitment hash (PartialBlockHash), via a separate HashChain step in PartialBlockHash::from_partial_block_hash_components after calculate_block_hash. BlockHashVersion::V0_14_3, STARKNET_BLOCK_HASH2, and the chain_if_fn block in calculate_block_hash were all removed. PR retitled accordingly: starknet_api: include fee_proposal_fri in proposal commitment hash. Added a unit test fee_proposal_fri_affects_partial_block_hash_but_not_block_hash to lock in the invariant. PTAL.
https://reviewable.io/reviews/starkware-libs/sequencer/13814#-OrEMx5P4-k9-bGZAH1C
|
Per reviewer feedback, proposal-commitment-hash binding moved out of starknet_api into the orchestrator. starknet_api stays unchanged. The new orchestrator-side helper will land in a new PR above this one in the stack. |
3 participants
No description provided.