apollo_consensus: use SM.id in SHC; remove local id

[asmaastarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[asmaastarkware]

• apollo_consensus: move caching decision logic to ConsensusCache #10620
• apollo_consensus: rename proposal cache and stream fields in manager #10619
• apollo_consensus: extract run_height_inner into focused helper funcs #10563
• apollo_consensus: use Round type alias instead of u32 #10541
• apollo_consensus: use BlockNumber for Vote.height #10507
• apollo_consensus: unify timeout scheduling requests into single enum variant #10482
• apollo_consensus: centralize future vote/proposal caching via ConsensusCache #10375
• apollo_consensus: refactor shc::handle_event into smaller helpers #10347
• apollo_consensus: make SHC synchronous; execute SMRequests in manager #10341
• apollo_consensus: add observer_does_not_record_self_votes test #10340
• apollo_consensus: SM now consumes events and emits requests; update SHC and tests #10339
• apollo_consensus: SM tracks last self votes not the SHC #10338
• apollo_consensus: move proposal storage to SM; dedupe in SHC #10337
• apollo_consensus: move vote storage to SM; dedupe in SHC #10336
• apollo_consensus: use Vote in Prevote/Precommit SMEvent #10335
• apollo_consensus: move height from SHC to SM #10356
• apollo_consensus: use SM.id in SHC; remove local id #10334 👈 (View in Graphite)
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

@dafnamatsry reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

---

crates/apollo_consensus/src/state_machine.rs line 135 at r2 (raw file):

    }

    pub(crate) fn id(&self) -> ValidatorId {

Suggestion:

pub(crate) fn validator_id(&self) -> ValidatorId {

[asmaastarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry)

---

crates/apollo_consensus/src/state_machine.rs line 135 at r2 (raw file):

    }

    pub(crate) fn id(&self) -> ValidatorId {

Done, although it will be deleted in the upcoming PRs

[dafnamatsry]

@dafnamatsry reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)