apollo_consensus: refactor shc::handle_event into smaller helpers #10347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2025
|
This change is |
This was referenced Nov 23, 2025
Contributor
Author
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
0be80a5 to
1bb5c54
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
e1f35b1 to
a2048b0
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
1bb5c54 to
b544b33
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
a2048b0 to
9215292
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
b544b33 to
24b4179
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
9215292 to
aba4f8b
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
24b4179 to
9c97e94
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
2 times, most recently
from
0ed6020 to
1dd77f1
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
9c97e94 to
109f67b
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
1dd77f1 to
9066d2f
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
2 times, most recently
from
713c560 to
e153d77
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
9066d2f to
234789d
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
e153d77 to
f74b17c
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
234789d to
9984fbf
Compare
matanl-starkware
approved these changes
Dec 2, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
5999658 to
dcd4690
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
2 times, most recently
from
8f9e25d to
b9db4a7
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
2 times, most recently
from
a9ec182 to
b9245a9
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
b9db4a7 to
cc1b52c
Compare
This was referenced Dec 2, 2025
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
cc1b52c to
c11137e
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
2 times, most recently
from
901ef96 to
ff2c6d0
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
c11137e to
8dfce6d
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
ff2c6d0 to
953660e
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
8dfce6d to
7aa75be
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
7aa75be to
b75e1da
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
branch
from
953660e to
be9f0c6
Compare
Base automatically changed from
asmaa/refactor/make_shc_synchronous_execute_smrequests_in_manager
to
main-v0.14.1
December 8, 2025 09:07
asmaastarkware
force-pushed
the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
from
b75e1da to
d8d714f
Compare
asmaastarkware
commented
Dec 8, 2025
Contributor
Author
asmaastarkware
left a comment
asmaastarkware
left a comment
There was a problem hiding this comment.
@asmaastarkware reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
asmaastarkware
deleted the
asmaa/refactor/refactor_shc_handle_event_into_smaller_helpers
branch
This was referenced Dec 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.