apollo_consensus: use Vote in Prevote/Precommit SMEvent

[asmaastarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[asmaastarkware]

• apollo_consensus: move caching decision logic to ConsensusCache #10620
• apollo_consensus: rename proposal cache and stream fields in manager #10619
• apollo_consensus: extract run_height_inner into focused helper funcs #10563
• apollo_consensus: use Round type alias instead of u32 #10541
• apollo_consensus: use BlockNumber for Vote.height #10507
• apollo_consensus: unify timeout scheduling requests into single enum variant #10482
• apollo_consensus: centralize future vote/proposal caching via ConsensusCache #10375
• apollo_consensus: refactor shc::handle_event into smaller helpers #10347
• apollo_consensus: make SHC synchronous; execute SMRequests in manager #10341
• apollo_consensus: add observer_does_not_record_self_votes test #10340
• apollo_consensus: SM now consumes events and emits requests; update SHC and tests #10339
• apollo_consensus: SM tracks last self votes not the SHC #10338
• apollo_consensus: move proposal storage to SM; dedupe in SHC #10337
• apollo_consensus: move vote storage to SM; dedupe in SHC #10336
• apollo_consensus: use Vote in Prevote/Precommit SMEvent #10335 👈 (View in Graphite)
• apollo_consensus: move height from SHC to SM #10356
• apollo_consensus: use SM.id in SHC; remove local id #10334
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 3 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry)

---

crates/apollo_consensus/src/single_height_consensus.rs line 136 at r1 (raw file):

/// tasks). SHC does have side effects, such as sending messages to the network via the context.
pub(crate) struct SingleHeightConsensus {
    height: BlockNumber,

Can you split this into a PR "removing height from SHC"?

Code quote:

height: BlockNumber,

---

crates/apollo_consensus/src/single_height_consensus.rs line 415 at r1 (raw file):

                }
                StateMachineEvent::Precommit(vote) => {
                    ret_val.extend(self.handle_state_machine_vote(context, vote).await?);

Same behaviour as Prevote.
Consider using an unite arm

Code quote:

ret_val.extend

[asmaastarkware]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @matanl-starkware)

---

crates/apollo_consensus/src/single_height_consensus.rs line 136 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Can you split this into a PR "removing height from SHC"?

Done

---

crates/apollo_consensus/src/single_height_consensus.rs line 415 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Same behaviour as Prevote.
Consider using an unite arm

will be deleted in the upcoming PRs

[matanl-starkware]

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry)

---

crates/apollo_consensus/src/single_height_consensus.rs line 256 at r3 (raw file):

                context.broadcast(last_vote.clone()).await?;
                Ok(ShcReturn::Tasks(vec![ShcTask::Prevote(
                    self.timeouts.get_prevote_timeout(0),

This seems like a mixture of other PRs?

Code quote:

self.timeouts.get_prevote_timeout(0),

[matanl-starkware]

@matanl-starkware reviewed 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

@dafnamatsry reviewed 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)