apollo_consensus: move proposal storage to SM; dedupe in SHC

[asmaastarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[asmaastarkware]

• apollo_consensus: move caching decision logic to ConsensusCache #10620
• apollo_consensus: rename proposal cache and stream fields in manager #10619
• apollo_consensus: extract run_height_inner into focused helper funcs #10563
• apollo_consensus: use Round type alias instead of u32 #10541
• apollo_consensus: use BlockNumber for Vote.height #10507
• apollo_consensus: unify timeout scheduling requests into single enum variant #10482
• apollo_consensus: centralize future vote/proposal caching via ConsensusCache #10375
• apollo_consensus: refactor shc::handle_event into smaller helpers #10347
• apollo_consensus: make SHC synchronous; execute SMRequests in manager #10341
• apollo_consensus: add observer_does_not_record_self_votes test #10340
• apollo_consensus: SM now consumes events and emits requests; update SHC and tests #10339
• apollo_consensus: SM tracks last self votes not the SHC #10338
• apollo_consensus: move proposal storage to SM; dedupe in SHC #10337 👈 (View in Graphite)
• apollo_consensus: move vote storage to SM; dedupe in SHC #10336
• apollo_consensus: use Vote in Prevote/Precommit SMEvent #10335
• apollo_consensus: move height from SHC to SM #10356
• apollo_consensus: use SM.id in SHC; remove local id #10334
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dafnamatsry)

---

crates/apollo_consensus/src/state_machine.rs line 158 at r1 (raw file):

    pub(crate) fn proposals_ref(
        &self,
    ) -> &HashMap<Round, (Option<ProposalCommitment>, Option<Round>)> {

I'm not sure if this function is needed; if you accept my suggestions to have more fine-tuned getter functions for StateMachine.

Code quote:

&HashMap<Round, (Option<ProposalCommitment>, Option<Round>)>

---

crates/apollo_consensus/src/single_height_consensus.rs line 210 at r1 (raw file):

        // - If SM already has an entry for this round, a (re)proposal was already recorded.
        // - If we already started validating this round, ignore repeats.
        if self.state_machine.proposals_ref().get(&init.round).is_some()

Add fn to state_machine to check whether a round exists (-> bool)

Code quote:

.proposals_ref().get(&init.round).is_some()

---

crates/apollo_consensus/src/single_height_consensus.rs line 296 at r1 (raw file):

                // Validation for this round finished; clear the pending marker.
                self.pending_validation_rounds.remove(&round);

Didn't understand why this is done here

Code quote:

self.pending_validation_rounds.remove(&round);

---

crates/apollo_consensus/src/single_height_consensus.rs line 478 at r1 (raw file):

        // Make sure there is an existing proposal for the valid round and it matches the proposal
        // ID.
        let existing = self.state_machine.proposals_ref().get(&valid_round).and_then(|(id, _)| *id);

Create a fn for this

Code quote:

proposals_ref().get(&valid_round).and_then(|(id, _)| *id);

[asmaastarkware]

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @dafnamatsry and @matanl-starkware)

---

crates/apollo_consensus/src/single_height_consensus.rs line 296 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Didn't understand why this is done here

just for clean up, deleting it won't change the behaviour

[matanl-starkware]

@matanl-starkware reviewed 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

---

crates/apollo_consensus/src/single_height_consensus.rs line 296 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

just for clean up, deleting it won't change the behaviour

So maybe make the comment a little bit more clear?
Is it possible that we ran validation for this round and now it's our turn to propose?

[asmaastarkware]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @dafnamatsry and @matanl-starkware)

---

crates/apollo_consensus/src/single_height_consensus.rs line 296 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

So maybe make the comment a little bit more clear?
Is it possible that we ran validation for this round and now it's our turn to propose?

No, when we receive a proposal, we verify the proposer matches the expected one for that round. if we are the proposer for round R, any proposal from someone else for round R would fail this check and be rejected before validation starts

[dafnamatsry]

@dafnamatsry reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

---

crates/apollo_consensus/src/single_height_consensus.rs line 565 at r5 (raw file):

            .state_machine
            .proposal_id_for_round(round)
            .ok_or_else(|| invalid_decision("No proposal entry for this round".to_string()))?;

Not sure we need this check (and also the one in handle_state_machine_proposal).
This data is coming from the state machine to begin with.

Code quote:

        let block = self
            .state_machine
            .proposal_id_for_round(round)
            .ok_or_else(|| invalid_decision("No proposal entry for this round".to_string()))?;

[dafnamatsry]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

[matanl-starkware]

@matanl-starkware reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

[asmaastarkware]

@asmaastarkware reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)