apollo_consensus: add observer_does_not_record_self_votes test #10340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2025
|
This change is |
This was referenced Nov 23, 2025
Contributor
Author
This was referenced Nov 23, 2025
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
87290c0 to
db77f88
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
c66df95 to
3bac141
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
db77f88 to
4bb3c97
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
3bac141 to
08168d9
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
08168d9 to
66c4827
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
4bb3c97 to
47d26a6
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
66c4827 to
51b0df0
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
2 times, most recently
from
869a963 to
f153d27
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
2 times, most recently
from
91459da to
7e3b9a9
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
03e5d13 to
98c9447
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
7e3b9a9 to
28e5414
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
98c9447 to
887093f
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
28e5414 to
0874dc4
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
4f77bec to
177a3e8
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
c5ef828 to
1d184db
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
2 times, most recently
from
acffcd6 to
4c6e2c4
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
2 times, most recently
from
0718475 to
7028a75
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
4c6e2c4 to
5ec5c37
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
7028a75 to
5c79976
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
5ec5c37 to
416dd69
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
5c79976 to
d68e453
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
2 times, most recently
from
3d2c110 to
528df95
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
2 times, most recently
from
a0e3bc5 to
6c27fab
Compare
matanl-starkware
approved these changes
Nov 30, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
6c27fab to
69dd49b
Compare
asmaastarkware
force-pushed
the
asmaa/sm_now_consumes_events_and_emits_requests
branch
from
528df95 to
5acfb94
Compare
Base automatically changed from
asmaa/sm_now_consumes_events_and_emits_requests
to
main-v0.14.1
December 2, 2025 09:23
asmaastarkware
force-pushed
the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
from
69dd49b to
4c9afba
Compare
matanl-starkware
approved these changes
Dec 2, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
asmaastarkware
deleted the
asmaa/refactor/add_observer_does_not_record_self_votes_test
branch
This was referenced Dec 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.