apollo_storage: impl SerializeConfig for storage reader ServerConfig #10662
+52
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 9, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 9, 2025
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
767f9f3 to
a63da00
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
2 times, most recently
from
211e837 to
079f9a0
Compare
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
a63da00 to
d8b70ac
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
079f9a0 to
0311724
Compare
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
d8b70ac to
ddeb00d
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
0311724 to
846814d
Compare
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
ddeb00d to
cc3584f
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
846814d to
bed4068
Compare
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
cc3584f to
7785094
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
bed4068 to
2c2984e
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
2c2984e to
d379e9e
Compare
Itay-Tsabary-Starkware
approved these changes
Dec 15, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
d379e9e to
6796109
Compare
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
7785094 to
213edc2
Compare
nadin-Starkware
force-pushed
the
12-08-apollo_class_manager_types_add_classmanagerstoragereaderserverhandler
branch
from
213edc2 to
ccf08a5
Compare
nadin-Starkware
force-pushed
the
12-09-apollo_storage_impl_serializeconfig_for_storage_reader_serverconfig
branch
from
6796109 to
a298500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.