apollo_storage: add open_storage_with_metric_and_server fn #10781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
This was referenced Dec 15, 2025
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
a18a537 to
fb50736
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
branch
from
0c6efd9 to
c2010c6
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
fb50736 to
898a786
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
branch
from
c2010c6 to
c058dae
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
898a786 to
46069d4
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
branch
from
c058dae to
1bc0a55
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
46069d4 to
3434b39
Compare
Itay-Tsabary-Starkware
requested changes
Dec 15, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/apollo_storage/src/lib.rs line 167 at r1 (raw file):
use crate::state::data::IndexedDeprecatedContractClass; use crate::version::{VersionStorageReader, VersionStorageWriter};
Please keep the newline here
Itay-Tsabary-Starkware
approved these changes
Dec 15, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
nadin-Starkware
force-pushed
the
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
branch
from
1bc0a55 to
fd603a2
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
3434b39 to
7ed02bd
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
branch
from
fd603a2 to
c84a1ec
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
7ed02bd to
b6790b9
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
branch
from
c84a1ec to
84a3a52
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
b6790b9 to
08d23d1
Compare
graphite-app
bot
changed the base branch from
12-15-apollo_storage_pass_storagereader_to_create_storage_reader_server
to
graphite-base/10781
nadin-Starkware
force-pushed
the
graphite-base/10781
branch
from
84a3a52 to
fee3641
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
08d23d1 to
375227f
Compare
graphite-app
bot
changed the base branch from
graphite-base/10781
to
main-v0.14.1
Merge activity
|
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
375227f to
ac59e24
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
ac59e24 to
747eac6
Compare
nadin-Starkware
commented
Dec 16, 2025
Collaborator
Author
nadin-Starkware
left a comment
nadin-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/apollo_storage/src/lib.rs line 167 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please keep the newline here
Done.
This was referenced Dec 16, 2025
nadin-Starkware
commented
Dec 16, 2025
Collaborator
Author
nadin-Starkware
left a comment
nadin-Starkware
left a comment
There was a problem hiding this comment.
@nadin-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
Itay-Tsabary-Starkware
approved these changes
Dec 16, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.