apollo_batcher_config: add storage_reader_server_config to the batcher config #10787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
a18a537 to
fb50736
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
0c7b787 to
4b99b66
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
fb50736 to
898a786
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
2 times, most recently
from
4e4586f to
90093f9
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
2 times, most recently
from
46069d4 to
3434b39
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
90093f9 to
01e0442
Compare
Itay-Tsabary-Starkware
requested changes
Dec 15, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/apollo_deployments/resources/app_configs/batcher_config.json line 55 at r1 (raw file):
"batcher_config.storage.mmap_file_config.max_size": 1099511627776, "batcher_config.storage.scope": "StateOnly", "batcher_config.storage_reader_server_config.socket": "0.0.0.0:8080",
Please break this to ip and port 🙏
Code quote:
socket
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
01e0442 to
a2cc85e
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
3434b39 to
7ed02bd
Compare
nadin-Starkware
commented
Dec 15, 2025
Collaborator
Author
nadin-Starkware
left a comment
nadin-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/apollo_deployments/resources/app_configs/batcher_config.json line 55 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please break this to
ipandport🙏
Done in PR https://reviewable.io/reviews/starkware-libs/sequencer/10806
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
7ed02bd to
b6790b9
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
a2cc85e to
b29cf04
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
b29cf04 to
44f6d02
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
b6790b9 to
08d23d1
Compare
graphite-app
bot
changed the base branch from
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
to
graphite-base/10787
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
44f6d02 to
d220cf2
Compare
nadin-Starkware
force-pushed
the
graphite-base/10787
branch
from
08d23d1 to
ac59e24
Compare
nadin-Starkware
changed the base branch from
graphite-base/10787
to
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
This was referenced Dec 16, 2025
nadin-Starkware
force-pushed
the
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
branch
from
ac59e24 to
747eac6
Compare
nadin-Starkware
force-pushed
the
12-15-apollo_batcher_config_add_storage_reader_server_config_to_the_batcher_config
branch
from
d220cf2 to
4227929
Compare
This was referenced Dec 16, 2025
nadin-Starkware
changed the base branch from
12-15-apollo_storage_add_open_storage_with_metric_and_server_fn
to
main-v0.14.1
|
Artifacts upload workflows: |
Itay-Tsabary-Starkware
approved these changes
Dec 16, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 1 of 5 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.