apollo_storage: split ServerConfig socket into ip and port fields

[nadin-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nadin-Starkware]

• apollo_storage: split ServerConfig socket into ip and port fields #10806 : 2 dependent PRs (#10808 , #10829 ) 👈 (View in Graphite)
• apollo_batcher: add storage_reader_server to the batcher #10788
• apollo_batcher_config: add storage_reader_server_config to the batcher config #10787
• apollo_storage: add open_storage_with_metric_and_server fn #10781
• apollo_storage: pass StorageReader to create_storage_reader_server #10771
• apollo_storage: impl SerializeConfig for storage reader ServerConfig #10662 : 1 other dependent PR (#10663 )
• apollo_class_manager_types: add ClassManagerStorageReaderServerHandler #10630
• apollo_state_sync_types: add StateSyncStorageReaderServerHandler #10628
• apollo_batcher_types: add BatcherStorageReaderServerHandler #10627
• apollo_storage: add error handling tests for storage reader server #10613
• apollo_storage: add tests for storage reader server #10612
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-15T14:34:48Z
• Started at 2025-12-15T15:27:14Z
• Started at 2025-12-16T08:39:25Z
• Started at 2025-12-16T09:43:30Z
• Started at 2025-12-16T11:34:16Z
• Started at 2025-12-16T13:16:00Z
• Started at 2025-12-16T19:23:19Z

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 37 at r1 (raw file):

impl ServerConfig {
    /// Creates a new server configuration.
    pub fn new(ip: Ipv4Addr, port: u16, enable: bool) -> Self {

IpAddr, and instantiate with Ipv4Addr

Code quote:

Ipv4Addr

[nadin-Starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 37 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

IpAddr, and instantiate with Ipv4Addr

Done.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 37 at r2 (raw file):

impl ServerConfig {
    /// Creates a new server configuration.
    pub fn new(ip: Ipv4Addr, port: u16, enable: bool) -> Self {

The input type should be of the inner type; I meant that when creating an IpAddr instance you can use the Ipv4Addr ct'or
Example

sequencer/crates/apollo_http_server/src/test_utils.rs

Line 154 in 24fef82

let ip = IpAddr::from(Ipv4Addr::LOCALHOST);

Code quote:

(ip: Ipv4Addr

[nadin-Starkware]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_storage/src/storage_reader_server.rs line 37 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

The input type should be of the inner type; I meant that when creating an IpAddr instance you can use the Ipv4Addr ct'or
Example

sequencer/crates/apollo_http_server/src/test_utils.rs

Line 154 in 24fef82

let ip = IpAddr::from(Ipv4Addr::LOCALHOST);

Done.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 1 of 5 files at r1, 2 of 4 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

[graphite-app]

Merge activity

• Dec 16, 7:23 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)