apollo_l1_gas_price,deployment: rename eth_to_strk_oracle to exchange_rate_oracle#13877
Conversation
PR SummaryMedium Risk Overview Updates consensus orchestrator and integration tests to use the new oracle API/error names, and adjusts the dummy oracle server/test constants ( Updates CI and local deployment artifacts to build/deploy the renamed dummy oracle image/service ( Reviewed by Cursor Bugbot for commit 2f781aa. Bugbot is set up for automated code reviews on this repo. Configure here. |
dfa93fd to
c55e219
Compare
c55e219 to
2f781aa
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama partially reviewed 22 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).
crates/apollo_l1_gas_price/src/exchange_rate_oracle.rs line 33 at r1 (raw file):
pub mod exchange_rate_oracle_test; pub const EXCHANGE_RATE_DECIMALS: u64 = 18;
I think this will be different in the strk to usd oracle. Should probably move to config/ctor
Future PR
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).
crates/apollo_l1_gas_price/src/exchange_rate_oracle.rs line 33 at r1 (raw file):
Previously, ShahakShama wrote…
I think this will be different in the strk to usd oracle. Should probably move to config/ctor
Future PR
on it
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).
crates/apollo_l1_gas_price/src/exchange_rate_oracle.rs line 33 at r1 (raw file):
Previously, sirandreww-starkware (Andrew Luka) wrote…
on it
in #13881
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

No description provided.