Skip to content

apollo_l1_gas_price,deployment: rename eth_to_strk_oracle to exchange_rate_oracle#13877

Merged
sirandreww-starkware merged 1 commit intomainfrom
04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle
Apr 27, 2026
Merged

apollo_l1_gas_price,deployment: rename eth_to_strk_oracle to exchange_rate_oracle#13877
sirandreww-starkware merged 1 commit intomainfrom
04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

This was referenced Apr 26, 2026
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 26, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Medium Risk
Broad rename touches gas-price provider APIs, error types, and multiple deployment/test entrypoints; risk is mainly integration breakage if any downstream code or configs still expect the old names or Docker service identifiers.

Overview
Renames the L1 exchange-rate oracle component end-to-end from eth_to_strk_oracle to exchange_rate_oracle, including config structs, client traits, error variants, and the L1GasPriceProviderClient method (get_eth_to_fri_rateget_rate).

Updates consensus orchestrator and integration tests to use the new oracle API/error names, and adjusts the dummy oracle server/test constants (ETH_TO_STRK_QUANTIZATIONEXCHANGE_RATE_DECIMALS).

Updates CI and local deployment artifacts to build/deploy the renamed dummy oracle image/service (dummy_exchange_rate_oracle) and wire the config injector/workflow scripts to the new image/service names.

Reviewed by Cursor Bugbot for commit 2f781aa. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle branch 3 times, most recently from dfa93fd to c55e219 Compare April 26, 2026 13:01
@sirandreww-starkware sirandreww-starkware changed the title apollo_l1_gas_price,deployment: rename eth_to_strk_oracle to price_oracle apollo_l1_gas_price,deployment: rename eth_to_strk_oracle to exchange_rate_oracle Apr 26, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle branch from c55e219 to 2f781aa Compare April 26, 2026 13:26
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama partially reviewed 22 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


crates/apollo_l1_gas_price/src/exchange_rate_oracle.rs line 33 at r1 (raw file):

pub mod exchange_rate_oracle_test;

pub const EXCHANGE_RATE_DECIMALS: u64 = 18;

I think this will be different in the strk to usd oracle. Should probably move to config/ctor
Future PR

Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_l1_gas_price/src/exchange_rate_oracle.rs line 33 at r1 (raw file):

Previously, ShahakShama wrote…

I think this will be different in the strk to usd oracle. Should probably move to config/ctor
Future PR

on it

Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_l1_gas_price/src/exchange_rate_oracle.rs line 33 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

on it

in #13881

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 7016e65 Apr 27, 2026
18 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants