apollo_storage: add fee_proposal to StorageBlockHeader

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_storage: add fee_proposal to StorageBlockHeader #13813 👈 (View in Graphite)
• starknet_api: add fee_proposal to BlockHeaderWithoutHash #13811
• apollo_protobuf: add fee_proposal_fri to ProposalInit #13812 : 2 other dependent PRs (#13822 , #13935 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Changes the persisted block-header schema/serialization, which can break compatibility with existing on-disk data unless handled via migration/resync.

Overview
Adds fee_proposal (SNIP-35 recommended fee) to StorageBlockHeader and plumbs it through header read/write paths so append_header, get_block_header, and revert_header round-trip the value instead of defaulting it.

Updates storage serialization and test instance generation for StorageBlockHeader to include the new field, effectively extending the on-disk header schema.

^{Reviewed by Cursor Bugbot for commit 3c1f7e9. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Missing storage version bump for format change

High Severity

Adding fee_proposal to StorageBlockHeader changes the binary serialization format (via auto_storage_serde), but STORAGE_VERSION_BLOCKS is not bumped. The VersionZeroWrapper deserializer reads fields sequentially and returns None when bytes are exhausted, so all block headers stored before this change will silently fail to deserialize. A major version bump is needed to force a re-sync.

Additional Locations (1)

• crates/apollo_storage/src/header.rs#L111-L113

 

^{Reviewed by Cursor Bugbot for commit a87a8b7. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8a9ab4a. Configure here.}

[cursor]

Missing storage version bump for schema change

High Severity

Adding fee_proposal: GasPrice to StorageBlockHeader changes the binary serialization format generated by auto_storage_serde!, but STORAGE_VERSION_BLOCKS in lib.rs is not bumped. Existing database records serialized without this field will fail to deserialize (the macro's deserialize_from returns None when bytes are exhausted), silently making all previously stored block headers unreadable. A major version bump is needed to force a re-sync for existing databases.

Additional Locations (1)

• crates/apollo_storage/src/serialization/serializers.rs#L185-L186

 

^{Reviewed by Cursor Bugbot for commit 8a9ab4a. Configure here.}