Skip to content

apollo_dashboard: add SNIP-35 row#13954

Open
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_metricsfrom
05-04-apollo_dashboard_add_snip-35_row
Open

apollo_dashboard: add SNIP-35 row#13954
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_metricsfrom
05-04-apollo_dashboard_add_snip-35_row

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 4, 2026

PR Summary

Low Risk
Low risk: dashboard-only changes that add new panels/queries without altering runtime logic. Main risk is incorrect metric expressions/units causing misleading graphs.

Overview
Adds a new SNIP-35 row to the Apollo Grafana dashboard, exposing dynamic gas pricing metrics (fee_actual, fee_proposal, fee_target) and the STRK/USD oracle rate.

Wires the row into the Rust dashboard definition (get_snip35_row) and updates the generated dev_grafana.json with the corresponding PromQL queries and unit scaling (/ 1e9, / 1e18).

Reviewed by Cursor Bugbot for commit ec16cd6. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from 095dd65 to f5e6b88 Compare May 4, 2026 13:20
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from adfcffc to 989d6b3 Compare May 4, 2026 13:20
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from f5e6b88 to ecce043 Compare May 5, 2026 06:53
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


crates/apollo_dashboard/src/dashboard_definitions.rs line 93 at r1 (raw file):

            get_consensus_row(),
            get_consensus_streams_row(),
            get_snip35_row(),

Put this below l1_gas_price_row

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from ecce043 to a5edb13 Compare May 5, 2026 13:13
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 4ce566a to 964596f Compare May 5, 2026 13:13
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_dashboard/src/dashboard_definitions.rs line 93 at r1 (raw file):

Previously, ShahakShama wrote…

Put this below l1_gas_price_row

Done.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 964596f to edb1b57 Compare May 6, 2026 06:29
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d341bc0. Configure here.

Comment thread crates/apollo_dashboard/resources/dev_grafana.json Outdated
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from 354cf9c to ec16cd6 Compare May 8, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants