Skip to content

apollo_l1_gas_price_types,apollo_l1_gas_price: rename trait method eth_to_fri_rate to fetch_rate#13987

Open
sirandreww-starkware wants to merge 1 commit into05-04-apollo_dashboard_add_snip-35_rowfrom
05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate
Open

apollo_l1_gas_price_types,apollo_l1_gas_price: rename trait method eth_to_fri_rate to fetch_rate#13987
sirandreww-starkware wants to merge 1 commit into05-04-apollo_dashboard_add_snip-35_rowfrom
05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 6, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware self-assigned this May 6, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review May 6, 2026 13:22
@cursor
Copy link
Copy Markdown

cursor Bot commented May 6, 2026

PR Summary

Medium Risk
Renames a public trait method in apollo_l1_gas_price_types, which is a breaking API change for any downstream implementers/callers despite no behavior changes.

Overview
Renames ExchangeRateOracleClientTrait::eth_to_fri_rate to the more generic fetch_rate, updating the ExchangeRateOracleClient implementation, L1GasPriceProvider call site, and all related tests.

Updates the trait documentation to clarify that the rate semantics are determined by the configured URLs and are labeled by the owning field rather than the method name.

Reviewed by Cursor Bugbot for commit 385721d. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware changed the base branch from 05-04-apollo_dashboard_add_snip-35_row to graphite-base/13987 May 6, 2026 13:33
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch from feb9526 to 83bbe20 Compare May 6, 2026 13:49
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13987 to 05-04-apollo_dashboard_add_snip-35_row May 6, 2026 13:49
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from 354cf9c to ec16cd6 Compare May 8, 2026 12:36
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch from 83bbe20 to 385721d Compare May 8, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants