Skip to content

apollo_starknet_client: read fee_proposal_fri from feeder gateway#13986

Open
sirandreww-starkware wants to merge 1 commit into05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blobfrom
05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway
Open

apollo_starknet_client: read fee_proposal_fri from feeder gateway#13986
sirandreww-starkware wants to merge 1 commit into05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blobfrom
05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 6, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 6, 2026

PR Summary

Medium Risk
Changes the feeder-gateway get_block request shape and block header mapping to include SNIP-35 fee proposal data; main risk is compatibility if some gateways don’t accept/return the new query/field despite Option fallback.

Overview
Adds SNIP-35 support by requesting withSnip35Info=true on feeder-gateway get_block calls and parsing the returned fee_proposal_fri into BlockPostV0_13_1.

Propagates fee_proposal_fri into the produced starknet_api block header, updates test fixtures to a new block_post_0_14_3.json, and adds tests covering presence, backward-compat None, and round-tripping through to_starknet_api_block_and_events().

Reviewed by Cursor Bugbot for commit 1292e67. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 13055bc to f4453fd Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 7a517f4 to 1292e67 Compare May 6, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants