apollo_l1_provider: add test for each type of L1 event we filter on

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-07T11:42:20Z
• Started at 2025-12-07T13:15:16Z
• Started at 2025-12-07T13:17:31Z
• Started at 2025-12-08T09:46:20Z
• Started at 2025-12-09T08:48:06Z
• Started at 2025-12-09T16:14:06Z
• Started at 2025-12-09T16:18:38Z
• Started at 2025-12-10T08:38:37Z
• Started at 2025-12-10T14:49:04Z
• Started at 2025-12-11T10:59:29Z
• Started at 2025-12-11T12:54:34Z
• Started at 2025-12-15T12:43:28Z
• Started at 2025-12-15T21:29:01Z

[guy-starkware]

• papyrus_base_layer: delete l1_endpoint_monitor crate #10736
• papyrus_base_layer: delete monitored base layer #10731
• apollo_l1_provider: re-write FinalityTooHigh error as LatestBlockNumberTooLow #10729
• apollo_l1_provider: use cyclic base layer wrapper instead of monitored base layer #10703
• apollo_l1_provider: make sure wrong event types do not get scraped #10700
• papyrus_base_layer: gate integration tests #10671
• apollo_l1_provider: add test for each type of L1 event we filter on #10595 👈 (View in Graphite)
• papyrus_base_layer: test util for creating an ethereum base layer using a mock provider #10588
• papyrus_base_layer: extract check and cycle URLs into a helper function with logging #10618
• papyrus_base_layer: add CyclicBaseLayerWrapper #10412
• papyrus_base_layer: make BaseLayer trait functions mutable #10404
• papyrus_base_layer: add the option to cycle the URL directly into the base layer #10357
• papyrus_base_layer: add ordered list of provider URLs to the config #10354
• apollo_l1_provider: remove finality_too_high helper function, add MissingBlock error #10348
• apollo_l1_gas_price: add test for low latest L1 block number #10346
• apollo_l1_provider: add test for low latest L1 block number #10345
• apollo_l1_provider: replace mutex with atomic u64 in a scraper test #10344
• papyrus_base_layer: remove finality from base layer #10303
• papyrus_base_layer: remove latest_l1_block from base layer #10300
• apollo_central_sync: remove base layer call to latest_proved_block #10246
• papyrus_base_layer: add test for a base layer without a starknet contract #10242
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

@ShahakShama reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @guy-starkware)

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 41 at r1 (raw file):

const FAKE_HASH: &str = "0x1234567890123456789012345678901234567890123456789012345678901234";

// Each function signature is hashed using keccak257 to get the selector.

257? not 256?

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 44 at r1 (raw file):

// For example, LogMessageToL2(address,uint256,uint256,uint256[],uint256,uint256)
// becomes "db80dd488acf86d17c747445b0eabb5d57c541d3bd7b6b87af987858e5066b2b".
fn filter_to_hash(filter: &str) -> String {

I personally like putting tests at the top of the file and util functions at the bottom, but I leave it up to you

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 143 at r1 (raw file):

#[tokio::test]
async fn all_event_types_must_be_filtered_and_parsed() {

What about the other test? Where an event that shouldn't be parsed is generated and we make sure we don't parse it?
I'm ok with doing it in a different PR

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 143 at r1 (raw file):

#[tokio::test]
async fn all_event_types_must_be_filtered_and_parsed() {

Consider splitting this test to a test for each event

[guy-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ShahakShama)

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 41 at r1 (raw file):

Previously, ShahakShama wrote…

257? not 256?

Oops!

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 44 at r1 (raw file):

Previously, ShahakShama wrote…

I personally like putting tests at the top of the file and util functions at the bottom, but I leave it up to you

I agree in this case it is better.

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 143 at r1 (raw file):

Previously, ShahakShama wrote…

What about the other test? Where an event that shouldn't be parsed is generated and we make sure we don't parse it?
I'm ok with doing it in a different PR

I will look into it. I'm not sure if we have another event like that in the contract... In any case, different PR.

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 143 at r1 (raw file):

Previously, ShahakShama wrote…

Consider splitting this test to a test for each event

I will consider it :)

[guy-starkware]

Reviewable status: 7 of 8 files reviewed, 4 unresolved discussions (waiting on @ShahakShama)

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 143 at r1 (raw file):

Previously, guy-starkware wrote…

I will consider it :)

Having considered it, it will cause us to skip a very important step: checking that every item in event_identifiers_to_track() is represented in our parsing code. If we do a separate test for each, we'd have to remember to manually add any new log types.

[guy-starkware]

Reviewable status: 7 of 8 files reviewed, 4 unresolved discussions (waiting on @ShahakShama)

---

crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 143 at r1 (raw file):

Previously, guy-starkware wrote…

I will look into it. I'm not sure if we have another event like that in the contract... In any case, different PR.

So I'm going to add a test that LogMessageToL1 does not get filtered. It will be on the top of the PR stack.

[guy-starkware]

@guy-starkware reviewed 2 of 10 files at r4, 8 of 8 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)