-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_l1_provider: make sure wrong event types do not get scraped #10700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70ada25 to
caaeb3c
Compare
caaeb3c to
aacafad
Compare
6363378 to
0be4ae3
Compare
aacafad to
81208ff
Compare
0be4ae3 to
721ad60
Compare
81208ff to
fea8c9c
Compare
fea8c9c to
f0f752c
Compare
7965e5a to
5ab7c6a
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 159 at r1 (raw file):
let result = base_layer.events(0..=1, event_identifiers_to_track()).await; assert!(result.is_err(), "expected error");
Could you also check that the error type is correct
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 159 at r1 (raw file):
Previously, ShahakShama wrote…
Could you also check that the error type is correct
Done.
5ab7c6a to
a67a040
Compare
f0f752c to
02c736a
Compare
02c736a to
2644695
Compare
a67a040 to
5c4f47f
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

No description provided.