Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guy-starkware commented Dec 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware force-pushed the guyn/baselayer/test_gating branch from 7965e5a to 5ab7c6a Compare December 11, 2025 12:54
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 159 at r1 (raw file):

    let result = base_layer.events(0..=1, event_identifiers_to_track()).await;

    assert!(result.is_err(), "expected error");

Could you also check that the error type is correct

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_test_event_filters.rs line 159 at r1 (raw file):

Previously, ShahakShama wrote…

Could you also check that the error type is correct

Done.

@guy-starkware guy-starkware force-pushed the guyn/baselayer/test_gating branch from 5ab7c6a to a67a040 Compare December 15, 2025 12:43
@guy-starkware guy-starkware force-pushed the guyn/baselayer/dont_filter branch from f0f752c to 02c736a Compare December 15, 2025 12:43
@graphite-app graphite-app bot changed the base branch from guyn/baselayer/test_gating to graphite-base/10700 December 15, 2025 21:58
@guy-starkware guy-starkware force-pushed the guyn/baselayer/dont_filter branch from 02c736a to 2644695 Compare December 16, 2025 06:02
@graphite-app graphite-app bot changed the base branch from graphite-base/10700 to main-v0.14.1 December 16, 2025 06:03
@graphite-app
Copy link

graphite-app bot commented Dec 16, 2025

Merge activity

  • Dec 16, 6:03 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Dec 16, 6:03 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main-v0.14.1 with commit 24fef82 Dec 16, 2025
19 of 40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants