papyrus_base_layer: make BaseLayer trait functions mutable

[guy-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• papyrus_base_layer: delete l1_endpoint_monitor crate #10736
• papyrus_base_layer: delete monitored base layer #10731
• apollo_l1_provider: re-write FinalityTooHigh error as LatestBlockNumberTooLow #10729
• apollo_l1_provider: use cyclic base layer wrapper instead of monitored base layer #10703
• apollo_l1_provider: make sure wrong event types do not get scraped #10700
• papyrus_base_layer: gate integration tests #10671
• apollo_l1_provider: add test for each type of L1 event we filter on #10595
• papyrus_base_layer: test util for creating an ethereum base layer using a mock provider #10588
• papyrus_base_layer: extract check and cycle URLs into a helper function with logging #10618
• papyrus_base_layer: add CyclicBaseLayerWrapper #10412
• papyrus_base_layer: make BaseLayer trait functions mutable #10404 👈 (View in Graphite)
• papyrus_base_layer: add the option to cycle the URL directly into the base layer #10357
• papyrus_base_layer: add ordered list of provider URLs to the config #10354
• apollo_l1_provider: remove finality_too_high helper function, add MissingBlock error #10348
• apollo_l1_gas_price: add test for low latest L1 block number #10346
• apollo_l1_provider: add test for low latest L1 block number #10345
• apollo_l1_provider: replace mutex with atomic u64 in a scraper test #10344
• papyrus_base_layer: remove finality from base layer #10303
• papyrus_base_layer: remove latest_l1_block from base layer #10300
• apollo_central_sync: remove base layer call to latest_proved_block #10246
• papyrus_base_layer: add test for a base layer without a starknet contract #10242
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

@ShahakShama reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware)

---

crates/apollo_l1_provider/src/l1_scraper.rs line 73 at r1 (raw file):

        self.scrape_from_this_l1_block = Some(
            self.retry_until_base_layer_success(
                |this| Box::pin(this.fetch_start_block()),

Please add a comment explaining these shenanigens

---

crates/apollo_l1_provider/src/l1_scraper.rs line 351 at r1 (raw file):

    ) -> L1ScraperResult<T, BaseLayerType>
    where
        for<'a> FuncType: FnMut(

Please add a comment explaining these shenanigens

[guy-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama)

---

crates/apollo_l1_provider/src/l1_scraper.rs line 73 at r1 (raw file):

Previously, ShahakShama wrote…

Please add a comment explaining these shenanigens

Done.

---

crates/apollo_l1_provider/src/l1_scraper.rs line 351 at r1 (raw file):

Previously, ShahakShama wrote…

Please add a comment explaining these shenanigens

Honestly I don't know how to explain this.

[ShahakShama]

@ShahakShama reviewed all commit messages.
Reviewable status: 16 of 18 files reviewed, 2 unresolved discussions (waiting on @guy-starkware)

---

crates/apollo_l1_provider/src/l1_scraper.rs line 73 at r1 (raw file):

Previously, guy-starkware wrote…

Done.

I now see what made me not understand what's going on here. Use BoxFuture intead of Pin<Box (it's a type alias)

[ShahakShama]

@ShahakShama reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[ShahakShama]

@ShahakShama reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[graphite-app]

Merge activity

• Dec 9, 10:06 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[guy-starkware]

@guy-starkware reviewed 15 of 18 files at r1, 1 of 2 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)