apollo_l1_gas_price_types: rename EthToStrkOracleClientTrait to PriceOracleClientTrait

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE) #13857
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator: add SNIP-35 e2e test #13821
• apollo_consensus_manager: wire STRK/USD oracle into consensus manager #13820
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator: add fee_actual floor to EIP-1559 gas price calculation #13824
• apollo_consensus_orchestrator: add SNIP-35 fee_proposals sliding window #13817
• apollo_consensus_orchestrator,apollo_consensus_manager: add strk_exchange_rate_oracle field to deps #13823
• apollo_consensus_orchestrator: add SNIP-35 metrics #13816
• apollo_consensus_orchestrator: add SNIP-35 module tests #13815
• apollo_consensus_orchestrator: add SNIP-35 module #13854
• starknet_api: include fee_proposal_fri in proposal commitment hash #13814
• starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash #13822
• apollo_storage: add fee_proposal to StorageBlockHeader #13813
• apollo_protobuf: add fee_proposal_fri to ProposalInit #13812
• starknet_api: add fee_proposal to BlockHeaderWithoutHash #13811
• starknet_api: add BlockHashVersion::V0_14_3 variant #13876
• apollo_consensus_orchestrator_config: rename validate_price_per_height to validate_dynamic_config #13810
• apollo_integration_tests,deployment: rename dummy_eth_to_strk_oracle binary to dummy_price_oracle #13875
• apollo_l1_gas_price: rename EthToStrkOracle references to PriceOracle #13809
• apollo_l1_gas_price: rename eth_to_strk_oracle_test.rs to price_oracle_test.rs #13808
• apollo_l1_gas_price: rename ETH_TO_STRK_QUANTIZATION to ORACLE_PRICE_DECIMALS #13807
• apollo_l1_gas_price: rename eth_to_strk_oracle.rs to price_oracle.rs #13806
• apollo_l1_gas_price: rename EthToStrkOracleClient to PriceOracleClient #13805
• apollo_l1_gas_price_config: rename EthToStrkOracleConfig to PriceOracleConfig #13804
• apollo_l1_gas_price_types: rename get_eth_to_fri_rate to get_price on provider client #13803
• apollo_l1_gas_price_types: rename EthToStrkOracleClientTrait to PriceOracleClientTrait #13802 👈 (View in Graphite)
• apollo_l1_gas_price_types: rename EthToStrkOracleClientError to PriceOracleClientError #13801
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Pure trait/interface rename with mechanical updates to implementations and mocks; low functional risk beyond potential downstream compile breakage if any call sites were missed.

Overview
Renames the oracle client interface from EthToStrkOracleClientTrait to PriceOracleClientTrait in apollo_l1_gas_price_types.

Updates EthToStrkOracleClient, L1GasPriceProvider, and associated tests to depend on/implement the new trait, including switching mocks to MockPriceOracleClientTrait.

^{Reviewed by Cursor Bugbot for commit 1002ae4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[ShahakShama]

@ShahakShama reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

---

a discussion (no related file):
FYI this is a bit too small PR IMO. I would've united it with #13801