Skip to content

apollo_l1_gas_price_config: rename EthToStrkOracleConfig to PriceOracleConfig#13804

Closed
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_types_rename_get_eth_to_fri_rate_to_get_price_on_provider_clientfrom
04-19-apollo_l1_gas_price_config_rename_ethtostrkoracleconfig_to_priceoracleconfig
Closed

apollo_l1_gas_price_config: rename EthToStrkOracleConfig to PriceOracleConfig#13804
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_types_rename_get_eth_to_fri_rate_to_get_price_on_provider_clientfrom
04-19-apollo_l1_gas_price_config_rename_ethtostrkoracleconfig_to_priceoracleconfig

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_types_rename_get_eth_to_fri_rate_to_get_price_on_provider_client branch from d8667fe to f25137f Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_config_rename_ethtostrkoracleconfig_to_priceoracleconfig branch from 2d07315 to e57394b Compare April 23, 2026 11:59
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Low risk mechanical rename of a config type across the gas price oracle client and integration tests; behavior and serialized fields appear unchanged.

Overview
Renames the L1 gas price oracle configuration type from EthToStrkOracleConfig to PriceOracleConfig and updates all call sites.

This propagates through integration-test node setup (create_node_config callers), the EthToStrkOracleClient constructor/signature, and associated unit tests and provider config wiring (L1GasPriceProviderConfig.eth_to_strk_oracle_config).

Reviewed by Cursor Bugbot for commit e57394b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants