Skip to content

apollo_l1_gas_price: rename EthToStrkOracle references to PriceOracle#13809

Closed
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_rename_eth_to_strk_oracle_test.rs_to_price_oracle_test.rsfrom
04-19-apollo_l1_gas_price_apollo_consensus_orchestrator_rename_ethtostrkoracle_error_variants_and_log_message
Closed

apollo_l1_gas_price: rename EthToStrkOracle references to PriceOracle#13809
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_rename_eth_to_strk_oracle_test.rs_to_price_oracle_test.rsfrom
04-19-apollo_l1_gas_price_apollo_consensus_orchestrator_rename_ethtostrkoracle_error_variants_and_log_message

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Purely a naming/log-message cleanup (error variant + log string) with no behavioral changes to gas pricing or consensus flows; low risk aside from minor metric/error-label name mismatches in downstream consumers.

Overview
Renames consensus-orchestrator error variants/messages from EthToStrkOracle to PriceOracle in both proposal building and validation, aligning terminology with PriceOracleClientError.

Updates the PriceOracleClient::new startup log line to say Creating PriceOracleClient instead of Creating EthToStrkOracleClient.

Reviewed by Cursor Bugbot for commit 0b370d9. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_rename_eth_to_strk_oracle_test.rs_to_price_oracle_test.rs branch from e019505 to f262f2f Compare April 26, 2026 09:32
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_apollo_consensus_orchestrator_rename_ethtostrkoracle_error_variants_and_log_message branch from d75b26e to 0b370d9 Compare April 26, 2026 09:32
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants