apollo_consensus: unify timeout scheduling requests into single enum variant #10482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2025
|
This change is |
This was referenced Nov 30, 2025
Contributor
Author
This was referenced Nov 30, 2025
matanl-starkware
approved these changes
Nov 30, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
from
6bcafee to
58d513d
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
2 times, most recently
from
428db2b to
ecb5303
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
2 times, most recently
from
9b38c50 to
fb616be
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
ecb5303 to
81bdfcb
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
from
fb616be to
88934af
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
81bdfcb to
937b9a7
Compare
matanl-starkware
approved these changes
Dec 2, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
937b9a7 to
448566c
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
from
88934af to
ab048cf
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
448566c to
eb50988
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
from
ab048cf to
3829424
Compare
matanl-starkware
approved these changes
Dec 2, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
eb50988 to
0045f6c
Compare
This was referenced Dec 2, 2025
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
0045f6c to
a674f6d
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
2 times, most recently
from
fc6df0b to
c284d0c
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
2 times, most recently
from
a559b67 to
bf6cc66
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
from
c284d0c to
8f68956
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
from
8f68956 to
a2a3a88
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
2 times, most recently
from
9b240b3 to
b0543e1
Compare
asmaastarkware
force-pushed
the
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
branch
2 times, most recently
from
2538507 to
bb01ba5
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
b0543e1 to
eb935ba
Compare
This was referenced Dec 8, 2025
Base automatically changed from
11-24-apollo_consensus_centralize_future_vote_proposal_caching_via_consensuscache
to
main-v0.14.1
December 8, 2025 13:14
asmaastarkware
changed the base branch from
main-v0.14.1
to
graphite-base/10482
asmaastarkware
force-pushed
the
asmaa/refactor/unify_timeout_scheduling_requests
branch
from
eb935ba to
d52e421
Compare
asmaastarkware
force-pushed
the
graphite-base/10482
branch
from
bb01ba5 to
0464ca7
Compare
asmaastarkware
changed the base branch from
graphite-base/10482
to
main-v0.14.1
asmaastarkware
commented
Dec 8, 2025
Contributor
Author
asmaastarkware
left a comment
asmaastarkware
left a comment
There was a problem hiding this comment.
@asmaastarkware reviewed 1 of 4 files at r1, 1 of 2 files at r3, 2 of 2 files at r5, all commit messages.
Reviewable status:
asmaastarkware
deleted the
asmaa/refactor/unify_timeout_scheduling_requests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.