apollo_consensus: extract run_height_inner into focused helper funcs #10563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 4, 2025
Contributor
Author
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
2e86bde to
ca2f2a8
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
2 times, most recently
from
29d133e to
d3477e0
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
ca2f2a8 to
c61b9cc
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
d3477e0 to
a6a8db7
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
c61b9cc to
31c47d9
Compare
This was referenced Dec 8, 2025
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
31c47d9 to
36f48d0
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
2 times, most recently
from
03a9cfb to
ff4fef8
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
36f48d0 to
ec18b70
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
ff4fef8 to
4526b6e
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
2 times, most recently
from
010d4b0 to
86fae79
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
2 times, most recently
from
104e757 to
04002a1
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
86fae79 to
d078970
Compare
Base automatically changed from
asmaa/refactor/use_round_type_alias_instead_of_u32
to
main-v0.14.1
December 9, 2025 08:42
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
04002a1 to
66dec79
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
66dec79 to
0ec8945
Compare
dafnamatsry
approved these changes
Dec 10, 2025
Collaborator
dafnamatsry
left a comment
dafnamatsry
left a comment
There was a problem hiding this comment.
@dafnamatsry reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware)
asmaastarkware
deleted the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.