apollo_consensus: use Round type alias instead of u32 #10541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 3, 2025
Contributor
Author
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
d93f9d6 to
8e22da8
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
2 times, most recently
from
0460d3e to
278b84e
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
8e22da8 to
7beff96
Compare
matanl-starkware
requested changes
Dec 3, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry)
-- commits line 2 at r1:
Not really impacting the protobuf module
Code quote:
,apollo_protobuf
matanl-starkware
approved these changes
Dec 3, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry)
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
7beff96 to
51ad072
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
278b84e to
2e86bde
Compare
asmaastarkware
changed the title
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
2e86bde to
ca2f2a8
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
51ad072 to
0dfe0db
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
0dfe0db to
dad8c7d
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
2 times, most recently
from
c61b9cc to
31c47d9
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
dad8c7d to
0223f0c
Compare
This was referenced Dec 8, 2025
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
31c47d9 to
36f48d0
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
0223f0c to
31f17aa
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
36f48d0 to
ec18b70
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
2 times, most recently
from
09eec94 to
fde8c30
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
2 times, most recently
from
010d4b0 to
86fae79
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/use_blocknumber_for_vote.height
branch
from
fde8c30 to
de5d172
Compare
Base automatically changed from
asmaa/refactor/use_blocknumber_for_vote.height
to
main-v0.14.1
December 9, 2025 06:38
asmaastarkware
force-pushed
the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
from
86fae79 to
d078970
Compare
asmaastarkware
commented
Dec 9, 2025
Contributor
Author
asmaastarkware
left a comment
asmaastarkware
left a comment
There was a problem hiding this comment.
@asmaastarkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
asmaastarkware
deleted the
asmaa/refactor/use_round_type_alias_instead_of_u32
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.