apollo_consensus: rename proposal cache and stream fields in manager #10619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 8, 2025
Contributor
Author
This was referenced Dec 8, 2025
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
from
d1e5df5 to
5884ac0
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
a6a8db7 to
03a9cfb
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
from
5884ac0 to
f923141
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
03a9cfb to
ff4fef8
Compare
matanl-starkware
approved these changes
Dec 8, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
ff4fef8 to
4526b6e
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
2 times, most recently
from
4050971 to
e5d0769
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
4526b6e to
104e757
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
104e757 to
04002a1
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
from
e5d0769 to
30bc6f9
Compare
dafnamatsry
approved these changes
Dec 9, 2025
Collaborator
dafnamatsry
left a comment
dafnamatsry
left a comment
There was a problem hiding this comment.
@dafnamatsry reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
04002a1 to
66dec79
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
from
30bc6f9 to
383c26e
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/extract_run_height_inner_into_helpers
branch
from
66dec79 to
0ec8945
Compare
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
from
383c26e to
48f32d8
Compare
Base automatically changed from
asmaa/refactor/extract_run_height_inner_into_helpers
to
main-v0.14.1
December 10, 2025 12:57
asmaastarkware
force-pushed
the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
from
48f32d8 to
e3e6f36
Compare
asmaastarkware
deleted the
asmaa/refactor/rename_proposal_cache_and_stream_fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.