Skip to content

central_systest_blobs: first two bootstrap declares#13963

Merged
dorimedini-starkware merged 1 commit intomainfrom
04-30-central_systest_blobs_first_two_bootstrap_declares
May 6, 2026
Merged

central_systest_blobs: first two bootstrap declares#13963
dorimedini-starkware merged 1 commit intomainfrom
04-30-central_systest_blobs_first_two_bootstrap_declares

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Changes are confined to a regression test helper and dev-dependencies, with no production logic impact. Main risk is altering generated test blob/tx data and associated expectations.

Overview
Implements BlobFactory::boostrap_declare_tx to actually build a V3 declare transaction (internal RPC + executable), compute its transaction hash, and enqueue it for the next block.

Adds mockall as a dev-dependency and wires MockClassManagerClient expectations (get_sierra/get_executable) so blob/test generation can resolve the declared class when needed.

Reviewed by Cursor Bugbot for commit 206c9b8. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_first_two_bootstrap_declares branch from cfef6e4 to e018c29 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_refactor_skeleton_into_structured_factory branch from 6f48b03 to b2772b7 Compare May 5, 2026 11:56
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_refactor_skeleton_into_structured_factory to graphite-base/13963 May 5, 2026 13:29
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_first_two_bootstrap_declares branch from e018c29 to 206c9b8 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/13963 to main May 5, 2026 14:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Artifacts upload workflows:

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 8d0c6c0 May 6, 2026
42 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants