Skip to content

central_systest_blobs: deploy token contract#13972

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_blockfrom
04-30-central_systest_blobs_deploy_token_contract
Open

central_systest_blobs: deploy token contract#13972
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_blockfrom
04-30-central_systest_blobs_deploy_token_contract

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Updates the golden preconfirmed block/blob generation to include an additional contract deployment via an INVOKE_FUNCTION, changing deterministic fixtures and nonce handling. Risk is mainly around breaking downstream tests/consumers that assume the previous blob contents/transaction shapes.

Overview
Extends cende_blob_regression_test to actually deploy the ERC20 contract from the deployed operator account by adding an invoke-based deployment helper (make_operator_deploy_tx) with deterministic nonce tracking (NonceManager) and multicall calldata construction.

Refreshes the recorded fixtures (preconfirmed_block.json and blob_file_generation) to reflect the new third block/preconfirmed transaction (now an INVOKE_FUNCTION deploying the token and initializing storage/events), including updated hashes, nonces, receipts, and resource usage.

Reviewed by Cursor Bugbot for commit 0f8511a. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 694fc71 to 9672f60 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 1c6a757 to 05c3328 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 05c3328 to b7db825 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 9672f60 to b04d116 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from b7db825 to f831a9b Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 12e4044 to 0e28d9e Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from f831a9b to 0f8511a Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants