Skip to content

central_systest_blobs: declare the test contract#13974

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_expect_operator_and_fee_token_addressesfrom
04-30-central_systest_blobs_declare_the_test_contract
Open

central_systest_blobs: declare the test contract#13974
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_expect_operator_and_fee_token_addressesfrom
04-30-central_systest_blobs_declare_the_test_contract

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: changes are confined to systest blob/fixture generation and should only affect the regression test outputs, though it may require updating stored expected blobs.

Overview
Adds support for generating both bootstrap and regular fee-paying declare transactions via make_declare_tx, including nonce management and signing for non-bootstrap declares.

Updates the blob regression test to declare the TestContract from the operator after closing the ERC20 deployment block, and refreshes tracked fixtures (preconfirmed_block.json and the blob generation counter) to match the new preconfirmed DECLARE transaction and resulting receipts/state diffs.

Reviewed by Cursor Bugbot for commit 35e9bfe. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 4985223 to b6a01a6 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 7e39626 to 742c842 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch 2 times, most recently from 105ceed to be7907e Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 742c842 to 9714281 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 9714281 to 230aacb Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from be7907e to 35e9bfe Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants