Skip to content

blockifier: implement conversion from commitment state diff to state maps#13965

Open
dorimedini-starkware wants to merge 1 commit intomainfrom
04-30-blockifier_implement_conversion_from_commitment_state_diff_to_state_maps
Open

blockifier: implement conversion from commitment state diff to state maps#13965
dorimedini-starkware wants to merge 1 commit intomainfrom
04-30-blockifier_implement_conversion_from_commitment_state_diff_to_state_maps

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: the only behavior change is a new From<CommitmentStateDiff> for StateMaps impl gated behind test/feature = "testing", so it should not affect production code paths.

Overview
Adds a new (test-only) From<CommitmentStateDiff> for StateMaps conversion, enabling round-tripping between these diff representations. The conversion flattens storage_updates into the flat StateMaps.storage map and initializes declared_contracts to the default empty map.

Reviewed by Cursor Bugbot for commit fa42902. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_preconfirmed_block_creation branch from 74bea58 to eb6fe34 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-blockifier_implement_conversion_from_commitment_state_diff_to_state_maps branch from d63278f to 6c9bcb1 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_preconfirmed_block_creation branch from eb6fe34 to 6115833 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-blockifier_implement_conversion_from_commitment_state_diff_to_state_maps branch 2 times, most recently from 502ad26 to ac58318 Compare May 5, 2026 14:17
@graphite-app graphite-app Bot changed the base branch from 04-30-central_systest_blobs_implement_preconfirmed_block_creation to graphite-base/13965 May 6, 2026 07:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-blockifier_implement_conversion_from_commitment_state_diff_to_state_maps branch from ac58318 to fa42902 Compare May 6, 2026 07:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Artifacts upload workflows:

@graphite-app graphite-app Bot changed the base branch from graphite-base/13965 to main May 6, 2026 07:32
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 6, 2026

Merge activity

  • May 6, 7:32 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants