central_systest_blobs: support reverting invokes#13977
Conversation
PR SummaryLow Risk Overview Execution in both Reviewed by Cursor Bugbot for commit 735123b. Bugbot is set up for automated code reviews on this repo. Configure here. |
556eda2 to
c05cd6d
Compare
3996872 to
a433940
Compare
c05cd6d to
c2b98b3
Compare
33ba948 to
91f2ac3
Compare
c2b98b3 to
4b81e80
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 1 file and made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 161 at r2 (raw file):
}); struct TxPair {
please rename
(maybe TxData)
Code quote:
struct TxPair {crates/central_systest_blobs/src/cende_blob_regression_test.rs line 164 at r2 (raw file):
executable: ExecutableAccountTx, internal: InternalConsensusTransaction, should_revert: bool,
IMO easier to understand
Suggestion:
should_be_reverted4b81e80 to
ac488b5
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on nimrod-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 161 at r2 (raw file):
Previously, nimrod-starkware wrote…
please rename
(maybe TxData)
Done.
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 164 at r2 (raw file):
Previously, nimrod-starkware wrote…
IMO easier to understand
revert is a verb, I think the current name works well ("should the tx revert?")
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
91f2ac3 to
8e640b1
Compare
ac488b5 to
92a3d78
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 92a3d78. Configure here.
92a3d78 to
735123b
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).


No description provided.