Skip to content

central_systest_blobs: support reverting invokes#13977

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharingfrom
05-05-central_systest_blobs_support_reverting_invokes
Open

central_systest_blobs: support reverting invokes#13977
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharingfrom
05-05-central_systest_blobs_support_reverting_invokes

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: changes are confined to the central_systest_blobs regression test harness and only affect how tests model/validate reverted transactions.

Overview
Updates the blob regression test transaction pipeline to carry per-transaction expected outcome via a new TxData { executable, internal, should_revert } struct (replacing the previous tuple).

Execution in both close_block and preconfirmed block generation now asserts that execution_info.is_reverted() matches should_revert, and make_operator_invoke_tx accepts a should_revert flag (with existing call sites defaulting to non-reverting behavior).

Reviewed by Cursor Bugbot for commit 735123b. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread crates/central_systest_blobs/src/cende_blob_regression_test.rs Outdated
@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 556eda2 to c05cd6d Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 3996872 to a433940 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from c05cd6d to c2b98b3 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 33ba948 to 91f2ac3 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from c2b98b3 to 4b81e80 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 1 file and made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 161 at r2 (raw file):

    });

struct TxPair {

please rename
(maybe TxData)

Code quote:

struct TxPair {

crates/central_systest_blobs/src/cende_blob_regression_test.rs line 164 at r2 (raw file):

    executable: ExecutableAccountTx,
    internal: InternalConsensusTransaction,
    should_revert: bool,

IMO easier to understand

Suggestion:

should_be_reverted

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 4b81e80 to ac488b5 Compare May 5, 2026 12:41
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on nimrod-starkware and yoavGrs).


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 161 at r2 (raw file):

Previously, nimrod-starkware wrote…

please rename
(maybe TxData)

Done.


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 164 at r2 (raw file):

Previously, nimrod-starkware wrote…

IMO easier to understand

revert is a verb, I think the current name works well ("should the tx revert?")

Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_invoke_from_deploy_function_for_code_sharing branch from 91f2ac3 to 8e640b1 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from ac488b5 to 92a3d78 Compare May 5, 2026 14:17
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 92a3d78. Configure here.

Comment thread crates/central_systest_blobs/src/cende_blob_regression_test.rs Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 92a3d78 to 735123b Compare May 5, 2026 14:23
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants