Skip to content

central_systest_blobs: sort state diff in preconfirmed block#13971

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_deploy_operator_accountfrom
04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block
Open

central_systest_blobs: sort state diff in preconfirmed block#13971
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_deploy_operator_accountfrom
04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: changes are test/fixture-oriented and only add deterministic sorting to state diff serialization. Main risk is mismatched golden outputs if other code implicitly relied on the previous nondeterministic ordering.

Overview
Makes preconfirmed block generation deterministic by adding a StarknetClientStateDiff::sort() helper (gated behind test/testing) and invoking it before serializing transaction_state_diffs in the central blob regression test.

Updates central_systest_blobs dev-dependency on apollo_batcher to enable the testing feature so the sorting helper is available during tests.

Reviewed by Cursor Bugbot for commit 0e28d9e. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 135396f to aa45046 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 694fc71 to 9672f60 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from aa45046 to 34b1097 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 9672f60 to b04d116 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 34b1097 to 19531c8 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from b04d116 to 12e4044 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_operator_account branch from 19531c8 to aa0ee34 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_state_diff_in_preconfirmed_block branch from 12e4044 to 0e28d9e Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants